Skip to content

EPIC: Align all EVM Keyrings to a common Keyring API #5152

Open
15 of 19 issues completed
Open

Description

@mikesposito

What is this about?
The Keyrings are among the application's most security-critical components. They manage private keys and enable seamless interaction with hardware wallets and other accounts.

However, the current keyring implementations suffer from architectural inconsistencies, outdated patterns, and technical debt, making them difficult to maintain, extend, and test. This has resulted in bugs, regressions, and blocked feature development, such as adding support for multiple Ledger devices.

The remaining work involves aligning all EVM native keyrings (HD, Ledger, Trezor, QR, and Lattice) to a standardized API, migrating non-TypeScript keyrings like HD to improve type safety and maintainability, and implementing bridges to enable comprehensive end-to-end testing.

Primary Outcome/Benefits

  • Enhanced Security: Robust Keyrings reduce vulnerabilities.
  • Improved Maintainability: Standardized API and TypeScript simplify updates.
  • Faster Feature Development: Unblocks features like multiple Ledger devices.
  • Better Testability: End-to-end testing reduces bugs and regressions.
  • Consistent Architecture: Unified Keyring implementations improve usability.
  • Higher Code Quality: TypeScript migration ensures type safety.
  • Seamless User Experience: Stable, reliable interactions with accounts and wallets.

This EPIC is intended as an index for all the work needed to reach this goal.

Activity

  1. added theissue type on May 19, 2025
  2. exalate-issue-sync commented on May 14, 2026

    @exalate-issue-sync

    Ajeet Dhaliwal commented: Follow up: Still relevant? Is accounts team doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions