This repository was archived by the owner on Sep 11, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 11, 2026. It is now read-only.
Fix Keyring serialize and deserialize type signature #128
Description
Activity
- changed the title
[-]Fix Keyring `deserialize` type signature[/-][+]Fix Keyring `serialize` and `deserialize` type signature[/+]on Aug 4, 2023 - added a parent issue
on Jan 20, 2025 @Gudahtt were you planning on assigning
unknownto bothserialize's return type anddeserialize's accepted argument? In that case we would probably get rid of the wholeStategeneric since it is only used withserializeanddeserialize.Also, instead of
unknown, perhaps it should still beJson?Agreed that we don't seem to have a need for that generic anymore.
And yes, you're right,
Jsondoes seem safe to assume here.- added a commit that references this issue
on Feb 5, 2025 - added a commit that references this issue
on Feb 12, 2025 - added a commit that references this issue
on Sep 21, 2026
The type for the keyring
deserializeandserializemethods wrongly state that the full keyring state is expected. The deserialize method should accept the serialized state, which is not the same as the keyring state. We should update these methods to expectunknownas the state type.