This repository was archived by the owner on Sep 11, 2026. It is now read-only.
Repository navigation
fix!: Keyring.serialize and Keyring.deserialize types - #232
Merged
Merged
Conversation
mikesposito
changed the title
Keyring.serialize and Keyring.deserialize typesKeyring.serialize and Keyring.deserialize types
ccharly
approved these changes
Feb 5, 2025
jeffsmale90
added a commit
that referenced
this pull request
Feb 10, 2025
…)" This reverts commit 368a7c6.
github-merge-queue Bot
pushed a commit
to MetaMask/accounts
that referenced
this pull request
Feb 12, 2025
This PR is reapplying [these changes](MetaMask/utils#232) to the Keyring type, which were reverted in the original repo. Fixes: MetaMask/utils#128
ccharly
pushed a commit
to MetaMask/accounts
that referenced
this pull request
Feb 13, 2025
This PR is reapplying [these changes](MetaMask/utils#232) to the Keyring type, which were reverted in the original repo. Fixes: MetaMask/utils#128
ccharly
pushed a commit
to MetaMask/accounts
that referenced
this pull request
Feb 20, 2025
This PR is reapplying [these changes](MetaMask/utils#232) to the Keyring type, which were reverted in the original repo. Fixes: MetaMask/utils#128
pull Bot
pushed a commit
to Reality2byte/core
that referenced
this pull request
Sep 10, 2026
Reverts the changes introduced by MetaMask/utils#232 in order to allow MetaMask/utils#231 to be released as a minor update on the current published version without requiring a major version bump. This change will be re-introduced after release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deserializeandserializemethods present wrong signatures as they expect theState extends Jsongeneric type passed to theKeyringfor their arguments and return value.They now present the following signatures:
serialize(): Promise<Json>deserialize(state: Json): Promise<void>Since now the
State extends Jsongeneric is unused, it has been removed from theKeyringtypeserializeanddeserializetype signature #128