You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
KeyringController addNewKeyring should not return the keyring instance #5371
The addNewKeyring method from KeyringController returns the keyring instance that was just created. However, this practice creates a loophole in controller safeguards, because the client will be incentivized to use the keyring instance directly instead of using KeyringController's dedicated API.
addNewKeyring should return the newly created keyring metadata, instead of the instance. The client can then use the ID with withKeyring to interact with the keyring instance safely.
Activity