Skip to content

[KeyringController] No specific error is thrown when the controller is locked #5171

Closed
#5172
Closed
[KeyringController] No specific error is thrown when the controller is locked#5171
#5172
Assignees
mikesposito
Labels
bugSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Description

@mikesposito
mikesposito
opened on Jan 17, 2025

No specific error is thrown when a certain operation is attempted while KeyringController.state.isUnlocked is false. This doesn't make the operations possible but doesn't give a clear error message either.

See MetaMask/metamask-extension#20317

Activity

  1. mikesposito
    added
    team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.
    bugSomething isn't working
    on Jan 17, 2025
  2. desi
    added a parent issue on Jan 21, 2025
  3. desi
    assigned
    mikesposito
    on Jan 27, 2025
  4. mikesposito
    closed this as completedin #5172on Feb 11, 2025
  5. mikesposito
    closed this as completedin 060c729on Feb 11, 2025
  6. matthewwalsh0
    added a commit that references this issue on Feb 11, 2025

    fix: throw explicit error when `KeyringController` is locked (#5172)

    060c729
  7. github-merge-queue
    added a commit that references this issue on Feb 19, 2025

    chore: bump `@metamask/keyring-controller` to `^19.1.0` (#30367)

    f73fd30
  8. javiergarciavera
    added a commit that references this issue on Feb 20, 2025

    chore: bump `@metamask/keyring-controller` to `^19.1.0` (#30367)

    f15c0fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions