Skip to content

Create ADR for keyring to allow adding an account non-sequentially  #5154

Open

Description

@mikesposito

Currently, our Keyring type only allows adding new accounts sequentially, or more specifically, does not provide a standardized way to specify which index (or even derivation path) should be used to derive the next available account.

This is fine for our current hierarchical deterministic wallet mechanics as users are only allowed to derive sequential indexes, but presents a limit for hardware device interactions since:

  • Users can preview the derivable accounts in a paginated manner
  • Users can select specific indexes to derive, which are not required to be sequential

This limitation is currently worked around by clients, that interact directly with each keyring that is known to support specific methods to handle pagination and to set derivation path index, but it would be nice to have a standard way to support this (e.g. through new methods on the shared Keyring type or by creating a pagination helper wrapper)

We should propose a solution to this problem through an ADR.

Activity

  1. changed the title [-]Create ADR for keyring type-agnostic non-sequential account unlock API[/-] [+]Create ADR for keyring to allow adding an account non-sequentially [/+] on Jan 20, 2025
  2. mcmire commented on Jun 4, 2025

    @mcmire
    Collaborator

    An ADR was posted here where this ticket was discussed, however, that discussion stalled. It seems that this approach is not BIP-44-compliant.

    We will put this ticket on ice for now until we work out a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions