fix(web,mobile): disabled provider instances no longer badge their siblings

[tris203]

Disabled provider instances counted toward badges on their enabled siblings. Managed Codex snapshots also reported disabled instances as enabled, and mobile's sidebar projection dropped the enabled field.

Count only enabled siblings for an enabled instance, preserve distinguishing badges on historical disabled accounts, and carry enabled state through managed snapshots and both clients' memoized sidebar data. The web sidebar keeps the server's project-aware enabled state while applying instance branding.

Rebuilt from @tris203's #14545, preserving the contributor commits and merging main.

Verification:

• 98 tests pass across the shared badge, mobile thread projection/resolution, web provider entry, mobile projection, and managed Codex suites. Added cases reduced from 5 to 4 across 5 changed test files; browser fixture updated for enabled state.
• Reverting each affected behavior makes its regression assertion fail. Both independent reviewers found the all-disabled historical-account case; the existing test now covers it and failed before the review fix.
• Two adversarial review rounds: the first found the all-disabled historical case; both reviewers returned no findings in the second.
• Scoped web, mobile, server and client-runtime typechecks, targeted lint and formatting pass.
• Headless Linux web against isolated seeded state: default Codex threads lose their badge when ChatGPT Personal is disabled; its historical thread retains CP. Enabling/disabling in Settings restores/removes the composer badge without reloading. With both accounts disabled, their historical threads retain distinct CO/CP badges; re-enabling the default removes only its unnecessary badge. No provider turns were submitted.

Before (main, same sidebar fixture):

After:

Not verified live: macOS, Windows, native iOS/Android, Electron desktop, remote/relay connections, or a real account turn. Native mobile behavior has focused projection/resolution coverage; these screenshots are the web client.

Implementation: Codex gpt-6.1-sol (high); tests: Codex gpt-6-astra (high); adversarial review: Claude claude-opus-5-5 and Codex gpt-6-sol, through T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 05b815c

Macroscope's review found this PR approvable — This is a contained bug fix that propagates provider enablement through existing web, mobile, and managed Codex display paths, with targeted regression coverage. Its runtime impact is limited to accurate provider badges and snapshot status, with no schema, deployment, security, billing, or default changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: cd3897c
• Latest commit, not reviewed: 05b815c

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: b3557238-cd16-47fb-81b8-7ae2ae4e19d8

📥 Commits

Reviewing files that changed from the base of the PR and between 611132c and cd3897c.

📒 Files selected for processing (9)

• apps/mobile/src/features/threads/thread-provider-instance.test.ts
• apps/mobile/src/features/threads/thread-provider-instance.ts
• apps/mobile/src/state/thread-list-environments.test.ts
• apps/mobile/src/state/thread-list-environments.ts
• apps/server/src/provider/Drivers/CodexDriver.test.ts
• apps/server/src/provider/Drivers/CodexManagedProvider.ts
• apps/web/src/components/chat/ThreadRelationshipsControl.agents.test.tsx
• packages/client-runtime/src/state/providerInstanceDisplay.test.ts
• packages/client-runtime/src/state/providerInstanceDisplay.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Mobile provider selection and comparison now carry enabled status. Instance-badge selection uses that status when counting same-driver providers. Managed Codex provider configuration also receives the instance’s enabled value.

Changes: Provider instance badges

Layer / File(s)	Summary
Track provider enabled state apps/mobile/src/state/thread-list-environments.ts, apps/mobile/src/state/thread-list-environments.test.ts, apps/mobile/src/features/threads/thread-provider-instance.test.ts, apps/mobile/src/features/threads/thread-provider-instance.ts	Selected mobile providers include enabled, and provider comparisons check it. The badge caller supplies enabled states. Tests include enabled provider values.
Enabled-aware badge selection packages/client-runtime/src/state/providerInstanceDisplay.ts, packages/client-runtime/src/state/providerInstanceDisplay.test.ts	shouldShowInstanceBadge skips disabled candidates when counting same-driver instances. Tests cover enabled and disabled combinations, ACP registry matching, and existing badge cases. An accent color still causes a badge.

Managed Codex enabled state

Layer / File(s)	Summary
Preserve disabled state apps/server/src/provider/Drivers/CodexManagedProvider.ts, apps/server/src/provider/Drivers/CodexDriver.test.ts	Managed Codex provider creation passes the instance’s enabled value to the pending provider. A test checks disabled initial and refreshed snapshots without spawning a process.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to cd389

Provider badges receive enabled state, and managed Codex providers retain their disabled state. No merge-blocking regression is established.

Security architecture risk: ⚪ Minimal · up to cd389

The change corrects disabled-account status and badge display without expanding access to accounts, credentials, or environments. No material security risk was identified in the changed behavior.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The reviewed change affects existing provider snapshot publication and provider-instance display within connected environments. The inspected paths introduce no new credential sink, execution interface, or cross-environment provider lookup.

Trust Boundaries and Controls

• observed — The corrected snapshot field does not become a new source of session authority. Provider runtime closures and authentication-wrapped session dispatch remain unchanged. Mobile consumers use enabled for row badge display, with action inputs supplied separately.

Pre-merge checks: 5

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Approvability		Pass. The pull request is a focused bug fix with related tests across 9 files and 61 added lines. It changes badge visibility and reports an existing provider field correctly. It does not change packa…
Title check		The title clearly identifies the main fix: disabled provider instances no longer add badges to sibling instances. It is concise and specific.
Description check		The description explains the problem, implementation, affected clients, verification results, screenshots, and unverified environments. It does not use the template headings or provide explicit mainta…

Full details: Approvability

Explanation

Pass. The pull request is a focused bug fix with related tests across 9 files and 61 added lines. It changes badge visibility and reports an existing provider field correctly. It does not change packages/contracts, persisted data, dependencies, authentication, external side effects, CI, release settings, or review configuration. It adds no static-analysis suppression and does not add a subsystem, workflow, or large refactor.

Full details: Description check

Explanation

The description explains the problem, implementation, affected clients, verification results, screenshots, and unverified environments. It does not use the template headings or provide explicit maintainer approval, but it includes scope context through the related pull request and describes this as a focused bug fix.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 41a3da6

[tris203]

Note

Opus 5.5 responding on behalf of @tris203

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Incremental review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[tris203]

Note

Opus 5.5 responding on behalf of @tris203

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

Dismissing prior approval to re-evaluate c33c436

[juliusmarminge]

Taking over this one. I’ll resolve main’s conflicts, keep the badge behavior consistent through shared state and managed Codex snapshots, and refresh the web proof before pushing to this branch.

Dismissing prior approval to re-evaluate 05b815c