fix(web): a closed proactive diff stays closed when you return to a thread

[ilyaliao]

Completed-turn diffs reopen when you return to a thread, even after you dismiss them. Persist the completed run whose diff was offered in the existing thread-scoped panel state, so dismissal survives navigation and reload while the next qualifying run can still open Diff.

A qualifying offer is also consumed when a manual choice or an active Diff/PR panel prevents opening. Eligibility remains in the existing resolver; panel priority stays in the store. A refused offer returns before resetting Diff scope or invoking the open callback. Manual opening, environment/thread isolation, checkpoint readiness, size thresholds, and the Proactive panels setting retain their existing behavior. Removed the original copy-forward helper because current panel actions already preserve thread state.

Maintainer takeover of @ilyaliao's #14705, preserving their commits and merging main without rewriting the fork branch. Web and Electron share this renderer; mobile has separate navigation and is unchanged.

Verification at 71ee529:

• Replaced six added cases in one existing test file with two persisted-state lifecycle cases. Focused store/resolver suites: 231 → 227 cases. Four related suites: 254 passing. Both new lifecycle cases fail against main; the review correction first produced three failures, then all 254 passed.
• Scoped web typecheck, lint, formatting, and whitespace checks pass. Lint retains four pre-existing unused-import warnings in the existing resolver test file.
• Two fresh parallel Claude Opus 5.5 / GPT-6 Sol review rounds. Round 1 found a completion while Diff/PR was active bypassed consumption; fresh test and implementation agents corrected that. Round 2 found no blockers.
• Real Linux Chromium client with isolated synthetic completed-run/checkpoint projections: first offer opens; hide → another thread → return and reload stays hidden; next completed run opens; a later run observed while Diff is active is consumed, and closing/returning/reloading stays closed. Explicit manual reopening works. These are client fixtures, not executed provider turns. The server was stopped before fixture writes; the thread snapshot cache was refreshed after fixture changes while panel persistence was retained.

After: dismissed Diff stays closed after returning and reloading (current head).

Dismiss, switch threads, return, and reload recording · Active-Diff completion dismissal recording · Fixture observations and limits.

Limits: no matching base screenshot/recording was captured; before/after regression tests provide the baseline proof under the requested test-level fallback. Initial browser captures lost text and one tab disappeared; the replacement tab produced the usable current-head captures above. Clearing the fixture snapshot cache reset Diff scope during hydration, so exact scope preservation during a real provider completion remains test-level proof. Single-PR priority, migration/pruning, and cross-environment cases were verified by focused tests. macOS, Windows, Electron desktop, iOS, Android, relay/tunnel connections, and a real provider-completion flow were not run here.

Current-head CI: lint, build/typecheck, all eight server shards, package tests, web tests, aggregate Check, fingerprint checks, and configured bot reviews passed. The initial web run hit an unchanged ACP Registry debounce/Enter timing race; the rerun passed. No unresolved review threads.

Implementation: GPT-6.1 Sol through Codex; tests: GPT-6 Astra through Codex; independent reviews: Claude Opus 5.5 through Claude Code and GPT-6 Sol through Codex, delegated by T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 71ee529

Macroscope's review found this PR approvable — This is a focused web UI bug fix that records which completed run was offered and prevents dismissed or declined diffs from reopening after navigation or reload. The additive local persistence and panel-priority changes are contained within the existing right-panel store and covered by lifecycle tests.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: 654298b
• Latest commit, not reviewed: 71ee529

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: f0cebd95-aa79-4b03-a59d-d1c37f5edb98

📥 Commits

Reviewing files that changed from the base of the PR and between ed76c75 and 654298b.

📒 Files selected for processing: 3

• apps/web/src/components/ChatView.tsx
• apps/web/src/rightPanelStore.test.ts
• apps/web/src/rightPanelStore.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

ChatView now includes the completed turn ID in proactive diff requests. The right-panel store tracks offered turns, checks whether a diff can open, and restores the offer marker from persisted thread state. Tests cover dismissal, reload, repeat offers, later turns, and user-selected panels.

Changes: Proactive diff offers

Layer / File(s)	Summary
Turn-scoped request state and persistence apps/web/src/rightPanelStore.ts	The right-panel state and request type track diff offers by turn ID. Thread updates preserve the marker, and persisted state restores it.
Proactive diff offer flow apps/web/src/components/ChatView.tsx, apps/web/src/rightPanelStore.ts, apps/web/src/rightPanelStore.test.ts	ChatView sends the completed turn ID with a diff request. The store prevents repeat offers for that turn, checks whether the diff can open, and records the turn even when it does not open. Tests cover dismissal, persistence, later turns, and user-selected panels.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant ChatView
  participant RightPanelStore
  participant PersistedThreadState
  ChatView->>RightPanelStore: Request diff offer with completed turnId
  RightPanelStore->>RightPanelStore: Check prior offer and opening conditions
  RightPanelStore->>PersistedThreadState: Retain proactiveDiffTurnId

Loading

Suggested reviewers: saphid, t3dotgg

Merge Risk: ⚪ Minimal · up to 65429

No actionable issue is established in this change. The reported desktop behavior has not been confirmed against this version.

Security architecture risk: ⚪ Minimal · up to 65429

The change is confined to remembering automatic panel offers. The inspected flow preserves thread isolation and user-choice checks, without introducing additional access or privileges.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The inspected change affects renderer-local panel state and its persisted per-environment, per-thread record. Manipulating the new marker can influence automatic panel presentation; the traced use does not grant additional service or data-access authority.

Trust Boundaries and Controls

• observed — The store derives ownership from both environment and thread identity. Within the synchronous state update, it checks the current user-action revision and pull-request priority before opening a diff; recording a refused offer does not open a surface.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the primary fix: preventing a dismissed proactive diff from reopening when the user returns to a thread.
Description check		The description provides the problem, implementation approach, scope, verification results, limitations, review status, and UI evidence. It does not use the template headings and does not include a di…

Full details: Description check

Explanation

The description provides the problem, implementation approach, scope, verification results, limitations, review status, and UI evidence. It does not use the template headings and does not include a direct link to the triaged issue or an explicit maintainer approval comment, but the required information is otherwise substantially covered.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 43179b6

Dismissing prior approval to re-evaluate 410c41d

Dismissing prior approval to re-evaluate 5625739

Dismissing prior approval to re-evaluate 68db8d9

[vwgp8wkgjz-beep]

Still reproduces on the macOS desktop app, nightly 0.0.46-nightly.20261013.3053 (server running on Linux), with Proactive panels on. In multiple threads, the diff panel reopens every time I enter the thread, even after I close it. Turning Proactive panels off works around it. Would be glad to see this merged.

Dismissing prior approval to re-evaluate 654298b

Dismissing prior approval to re-evaluate a3abf64

[juliusmarminge]

Taking over this one as maintainer for batch worktree-git-07. Keeping contributor commits, merging current main, then focused tests and independent reviews. No merge planned.

Dismissing prior approval to re-evaluate 71ee529