Skip to content

test(desktop): remove redundant keyring module-load test - #13220

Merged
t3-code[bot] merged 2 commits into
mainfrom
test/prune-useless-tests-20260923-063058
Sep 23, 2026
Merged

t3-code[bot] merged 2 commits into
mainfrom
test/prune-useless-tests-20260923-063058

Conversation

@t3-code

@t3-code t3-code Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

summary

remove the redundant import-only test from ChromiumKeys.module.test.ts.

under the same throwing @napi-rs/keyring mock, the remaining macOS keychain-unavailable test imports ChromiumKeys.ts, invokes resolveChromiumKeys, and verifies the concrete typed failure. the removed test only checked that the identical cached import resolved, so it covered no additional implementation, branch, or failure mode.

verification

  • before: vp test run apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts (2 files, 10 tests passed)
  • after: vp test run apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts (2 files, 9 tests passed)
  • vp run knip:check (passed)
  • vp run --filter @t3tools/desktop typecheck (passed, existing suggestions only)
  • vp lint apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts --report-unused-disable-directives (passed)
  • vp fmt --check apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts (passed)
  • git diff --check (passed)
  • focused diff secret scan (passed)

model: gpt-5.6-sol
harness: hermes agent

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 23, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8a5ad6b

Macroscope's review found this PR approvable — This is a four-line deletion from a single ignored test path that removes redundant test coverage without changing product runtime behavior, defaults, or static-analysis configuration.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB −1 B (−0.0%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB +3 B (+0.0%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.4 KiB 6.4 KiB −4 B (−0.1%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.2 KiB 56.2 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 9 9 0 (0.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB −3 B (−0.0%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB +3 B (+0.0%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.4 KiB −6 B (−0.1%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: b21c545 · PR result: 8a5ad6b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 23, 2026 06:42

Dismissing prior approval to re-evaluate 8a5ad6b

@t3-code t3-code Bot changed the title test(desktop): remove redundant module-load tests test(desktop): remove redundant keyring module-load test Sep 23, 2026
@t3-code
t3-code Bot merged commit eb6c170 into main Sep 23, 2026
23 checks passed
@t3-code
t3-code Bot deleted the test/prune-useless-tests-20260923-063058 branch September 23, 2026 06:45
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 23, 2026
## What's Changed
* hatch/variant functions by @juliusmarminge in pingdotgg/t3code#13191
* refactor(web): context chips render through one ContextChip component by @juliusmarminge in pingdotgg/t3code#13192
* refactor(web): ui components drop their secondary className props by @juliusmarminge in pingdotgg/t3code#13193
* refactor(web): menu triggers and items stop restyling ui/menu by @juliusmarminge in pingdotgg/t3code#13205
* refactor(web): field controls stop restyling Input, Select, Combobox and Command by @juliusmarminge in pingdotgg/t3code#13206
* refactor(web): app code stops restyling sidebar, popover, table and misc ui exports by @juliusmarminge in pingdotgg/t3code#13207
* refactor(web): Button consumers outside the composer stop restyling it by @juliusmarminge in pingdotgg/t3code#13208
* refactor(web): composer controls own their look instead of restyling ui components by @juliusmarminge in pingdotgg/t3code#13209
* chore(web): no-restyle fails lint, and the ceiling gate goes by @juliusmarminge in pingdotgg/t3code#13210
* fix(mobile): recover from screen render errors by @juliusmarminge in pingdotgg/t3code#13197
* feat(web): navigate back and forward with mod+[ and mod+] by @juliusmarminge in pingdotgg/t3code#13212
* fix(web): sort title matches by recent activity by @Yash-Singh1 in pingdotgg/t3code#13219
* test(desktop): remove redundant keyring module-load test by @t3-code[bot] in pingdotgg/t3code#13220


**Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260923.2135...v0.0.43-nightly.20260923.2150

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260923.2150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants