test(desktop): remove redundant keyring module-load test - #13220
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a four-line deletion from a single ignored test path that removes redundant test coverage without changing product runtime behavior, defaults, or static-analysis configuration. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
macroscopeapp
Bot
dismissed
their stale review
September 23, 2026 06:42
Dismissing prior approval to re-evaluate 8a5ad6b
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 23, 2026
## What's Changed * hatch/variant functions by @juliusmarminge in pingdotgg/t3code#13191 * refactor(web): context chips render through one ContextChip component by @juliusmarminge in pingdotgg/t3code#13192 * refactor(web): ui components drop their secondary className props by @juliusmarminge in pingdotgg/t3code#13193 * refactor(web): menu triggers and items stop restyling ui/menu by @juliusmarminge in pingdotgg/t3code#13205 * refactor(web): field controls stop restyling Input, Select, Combobox and Command by @juliusmarminge in pingdotgg/t3code#13206 * refactor(web): app code stops restyling sidebar, popover, table and misc ui exports by @juliusmarminge in pingdotgg/t3code#13207 * refactor(web): Button consumers outside the composer stop restyling it by @juliusmarminge in pingdotgg/t3code#13208 * refactor(web): composer controls own their look instead of restyling ui components by @juliusmarminge in pingdotgg/t3code#13209 * chore(web): no-restyle fails lint, and the ceiling gate goes by @juliusmarminge in pingdotgg/t3code#13210 * fix(mobile): recover from screen render errors by @juliusmarminge in pingdotgg/t3code#13197 * feat(web): navigate back and forward with mod+[ and mod+] by @juliusmarminge in pingdotgg/t3code#13212 * fix(web): sort title matches by recent activity by @Yash-Singh1 in pingdotgg/t3code#13219 * test(desktop): remove redundant keyring module-load test by @t3-code[bot] in pingdotgg/t3code#13220 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260923.2135...v0.0.43-nightly.20260923.2150 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260923.2150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
remove the redundant import-only test from
ChromiumKeys.module.test.ts.under the same throwing
@napi-rs/keyringmock, the remaining macOS keychain-unavailable test importsChromiumKeys.ts, invokesresolveChromiumKeys, and verifies the concrete typed failure. the removed test only checked that the identical cached import resolved, so it covered no additional implementation, branch, or failure mode.verification
vp test run apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts(2 files, 10 tests passed)vp test run apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts(2 files, 9 tests passed)vp run knip:check(passed)vp run --filter @t3tools/desktop typecheck(passed, existing suggestions only)vp lint apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts --report-unused-disable-directives(passed)vp fmt --check apps/desktop/src/ipc/methods/preview.test.ts apps/desktop/src/preview/BrowserImport/ChromiumKeys.module.test.ts(passed)git diff --check(passed)model: gpt-5.6-sol
harness: hermes agent