refactor(web): field controls stop restyling Input, Select, Combobox and Command - #13206
Merged
Merged
Conversation
…and Command Drops every className restyle on the field-family ui exports (Input, NumberField*, InputGroup*, Combobox*, Select*, Command*, Autocomplete, Textarea). Only one ui file changes; everything else moves onto an existing variant or size, or restructures. Primitive change (a real concept, several consumers): - AutocompleteItem lays its children out with gap-2, like ComboboxItem content already does. Its only item consumer (SSH host suggestions) passed gap-2 by hand; CommandItem inherits it, so the palette and composer menus drop their gap overrides. Moved onto existing variants/sizes (drift, visible change accepted): - Dense numeric/hex inputs (browser viewport width/height, provider accent hex, theme token hex) use Input size="compact" + font="mono" instead of hand-shrunk sm inputs. The theme token hex field becomes a normal bordered compact input instead of a borderless tinted chip. - Keybinding "when" expression uses InputGroup + compact mono InputGroupInput with the unknown-condition warning as an inline-end addon; the header search uses InputGroup + addon icon instead of an absolutely placed icon and a reach-in padding override. Invalid state comes from aria-invalid, which the group already styles. - Keybinding recording state drops its primary tint; the focus ring and "Press shortcut" placeholder carry it. - Branch toolbar env/workspace selects and the branch combobox trigger lose their font/size/colour overrides; the branch trigger renders through ComposerControl size="xs", the owner of that resting look. - Diff panel base-ref trigger renders as Button ghost-muted size="xs" instead of a hand-built button recipe. - Legacy sidebar visible-thread stepper uses NumberField size="sm" as is. - ComboboxItem pe-* overrides, ComboboxItem font-medium, CommandGroupLabel and CommandFooter spacing tweaks, CommandDialogPopup p-0 (it has no padding), NumberField gap tweaks, redundant bg-background on Inputs, Textarea and AutocompleteEmpty text tweaks, SelectValue leading-7 and the StorageSettings NumberFieldInput padding are deleted outright. - ComposerCommandMenu rows use CommandItem's own padding and radius. Restructured: - Preview address bar: the hover-revealed "open in browser" button fades via a plain span inside the addon; the input no longer animates its padding. - Empty project-content search renders its message as a plain <p> instead of styling CommandPaletteContent's panel text. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
vouch:trusted
juliusmarminge
added this pull request to stack #13194
September 23, 2026 04:08
github-actions
Bot
added
the
size:L
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is primarily a broad UI restyling refactor, but it also changes the shared You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (24)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThis pull request updates styling across browser, branch, command, preview, and settings controls. It removes local class overrides, adopts compact or grouped input components in selected controls, changes the preview browser action layout, and lowers ChangesWeb controls
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No introduced issue identified here needs resolution before merging; proceed with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
cursor Bot
pushed a commit
to aaditagrawal/t3code
that referenced
this pull request
Sep 23, 2026
…and Command (pingdotgg#13206) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cursor Bot
pushed a commit
to aaditagrawal/t3code
that referenced
this pull request
Sep 23, 2026
…and Command (pingdotgg#13206) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 23, 2026
## What's Changed * hatch/variant functions by @juliusmarminge in pingdotgg/t3code#13191 * refactor(web): context chips render through one ContextChip component by @juliusmarminge in pingdotgg/t3code#13192 * refactor(web): ui components drop their secondary className props by @juliusmarminge in pingdotgg/t3code#13193 * refactor(web): menu triggers and items stop restyling ui/menu by @juliusmarminge in pingdotgg/t3code#13205 * refactor(web): field controls stop restyling Input, Select, Combobox and Command by @juliusmarminge in pingdotgg/t3code#13206 * refactor(web): app code stops restyling sidebar, popover, table and misc ui exports by @juliusmarminge in pingdotgg/t3code#13207 * refactor(web): Button consumers outside the composer stop restyling it by @juliusmarminge in pingdotgg/t3code#13208 * refactor(web): composer controls own their look instead of restyling ui components by @juliusmarminge in pingdotgg/t3code#13209 * chore(web): no-restyle fails lint, and the ceiling gate goes by @juliusmarminge in pingdotgg/t3code#13210 * fix(mobile): recover from screen render errors by @juliusmarminge in pingdotgg/t3code#13197 * feat(web): navigate back and forward with mod+[ and mod+] by @juliusmarminge in pingdotgg/t3code#13212 * fix(web): sort title matches by recent activity by @Yash-Singh1 in pingdotgg/t3code#13219 * test(desktop): remove redundant keyring module-load test by @t3-code[bot] in pingdotgg/t3code#13220 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260923.2135...v0.0.43-nightly.20260923.2150 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260923.2150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form fields stop restyling Input, Select, Combobox and Command. The only
components/uichange is a default:AutocompleteItemspaces its children withgap-2, likeComboboxItemcontent.Input size="compact" font="mono": the browser viewport size, the accent colour hex, and the theme editor hex field. The theme hex field is the biggest change: it becomes a normal bordered compact input instead of a borderless tinted chip.InputGroupwith the icon as an addon.InputGroupInput, with the unknown-condition warning in an end addon. The invalid state comes fromaria-invalid, so it uses the standard error colour.ComposerControl size="xs".Button ghost-muted xs.smsize.CommandItempadding and radius, so they are tighter.no-restylefindings: 499 → 402.No screenshots yet: these changes are verified by lint, typecheck and tests only.
Claude Opus 5.5 via Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit