refactor(web): context chips render through one ContextChip component

[juliusmarminge]

Button variant="chip" skipped buttonVariants entirely. Each chip site then assembled the pill from exported class constants (the tone maps, the interactive classes, the dismiss class), so every chip surface re-derived the look slightly differently.

ContextChip (components/ContextChip.tsx) now owns it. It is a chat feature component, not a components/ui primitive: nothing outside chat context uses it, so it lives with the chat code and gets no exemption from the lint rule.

• ContextChip takes a kind (file, mention, terminal, skill, pull request states, …) and a state (unresolved, invalid).
• Interactivity follows from what it renders as. A button or link gets the hover tint, the focus outline and the pointer. Image and video chips zoom instead.
• ContextChipLabel truncates the label. ContextChipAction is the in-chip icon button (editing a citation comment).

The composer, sent messages, the markdown file link, skills, terminal excerpts and citations all use it. variant="chip" and the class exports are gone. The markdown file link no longer draws a second focus ring from index.css. The background worktree setup pill becomes a Button (ghost-muted, micro), because it is a control and not context.

no-restyle findings: 623 → 603.

	Before	After
File link in a reply
Chip in a message

Claude Opus 5.5 via Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Style
  • Chat context chips—including files, skills, citations, images, terminal contexts, and review items—now share consistent styling, labels, icons, and interaction states.
  • Selected chips receive a clearer highlight, and chip labels truncate to fit their available space.
  • Chat links retain their visual distinction, with file links styled separately from other links.
• Bug Fixes
  • Expired terminal contexts now display an invalid state while retaining their accessible labels and expiration details.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	13.5 KiB	—	15.1 KiB	✅
Codex	Thread snapshot wire	—	7.1 KiB	—	7.3 KiB	✅
Codex	Live turn WebSocket wire	—	6.5 KiB	—	7.8 KiB	✅
Codex	Live turn WebSocket decoded	—	56.3 KiB	—	66.4 KiB	✅
Codex	Live turn messages	—	10	—	21	✅
Claude	Total thread wire	—	13.5 KiB	—	15.1 KiB	✅
Claude	Thread snapshot wire	—	7.1 KiB	—	7.3 KiB	✅
Claude	Live turn WebSocket wire	—	6.4 KiB	—	7.8 KiB	✅
Claude	Live turn WebSocket decoded	—	57.0 KiB	—	66.4 KiB	✅
Claude	Live turn messages	—	9	—	21	✅

Baseline: unavailable · PR result: c5cdcb6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This refactor introduces a shared ContextChip abstraction and rewires many existing composer, markdown, attachment, citation, terminal, pull-request, and transcript surfaces. Because it changes shared DOM, styling, focus/interaction behavior, and editor selection handling across production paths, its blast radius warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: e56ab3ae-1c1a-4f32-a35c-4b0c8343dee5

📥 Commits

Reviewing files that changed from the base of the PR and between 3df3fe1 and c5cdcb6.

📒 Files selected for processing (9)

• apps/web/src/components/ChatMarkdown.tsx
• apps/web/src/components/ComposerPromptEditorTiptap.tsx
• apps/web/src/components/ContextChip.tsx
• apps/web/src/components/chat/AssistantCitationChip.tsx
• apps/web/src/components/chat/FileTagChip.tsx
• apps/web/src/components/chat/MessagesTimeline.tsx
• apps/web/src/components/chat/SkillInlineText.tsx
• apps/web/src/components/composerContextPresentation.tsx
• apps/web/src/components/contextChipParts.tsx

Limit details: You’ve used all 10 included reviews currently available.

---

📝 Walkthrough

Walkthrough

This change adds shared chip components and updates composer, chat, and Markdown file-link renderers to use them. It also removes the prior chip styling constants and button variant, and adjusts chat Markdown link styles.

Changes

Shared inline chip migration

Layer / File(s)	Summary
Shared chip components and context renderers apps/web/src/components/ContextChip.tsx, apps/web/src/components/contextChipParts.tsx, scripts/lint-restyle-ceiling.ts	Adds chip kinds, labels, actions, and state styling. Context, pull-request, image, file, and unresolved chip renderers use the shared components.
Composer chip migration apps/web/src/components/ComposerPromptEditorTiptap.tsx, apps/web/src/components/composerContextPresentation.tsx, apps/web/src/components/composerInlineChip.ts	Composer editor and context presentation use shared chip components and selection styling. Composer-specific chip styling declarations are removed.
Chat chip migration apps/web/src/components/chat/*, apps/web/src/components/ui/button.tsx	Chat message, citation, skill, and terminal chips use shared components. The button chip variant and terminal surface prop are removed.
Markdown file-link rendering apps/web/src/components/ChatMarkdown.tsx, apps/web/src/components/chat/FileTagChip.tsx, apps/web/src/index.css	Markdown file links render as shared chips. File-link callback props and file-tag content props are simplified, and chat Markdown link styles are updated.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Suggested reviewers: chrisdeeming, flamboh

Merge Risk: ⚪ Minimal · up to c5cdc

Context chips in the composer, chat messages, citations, skills and Markdown file links now render through one shared chip component. The changes are presentational. Markdown file links keep their chip look rather than inheriting normal link colors. No outstanding issues block merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 27.03% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 37 functions across 13 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the main change: rendering context chips through a shared ContextChip component.
Description check	✅ Passed	The description explains what changed and why, and includes before-and-after screenshots for the UI changes. It omits the checklist and a video for interaction changes, but it is otherwise mostly comp…

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}