Revert "Merge pull request #42 from GalaxisBeast/main"

[patchzyy]

This reverts commit 1912292, reversing changes made to e498e62.

Summary by CodeRabbit

• Changes

  • Removed support for WUP-028 GameCube adapters, including adapter-specific configuration, status displays, port assignment, and rumble handling.
  • Controller settings now assign connected controllers directly to selected ports.
  • Improved controller index handling to preserve existing assignments and use available ports more reliably.

• Bug Fixes

  • Improved controller detection and assignment behavior when ports are configured or already in use.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e5077c24-934d-44e3-ab4e-5e0a7cc0a050

📥 Commits

Reviewing files that changed from the base of the PR and between 6d836da and 2d88f0f.

📒 Files selected for processing (11)

• .gitignore
• aurora-main/include/dolphin/pad.h
• aurora-main/lib/dolphin/pad/pad.cpp
• aurora-main/lib/input.cpp
• runtime/cmake/PublicProducts.cmake
• runtime/include/runtime_config.h
• runtime/include/wup028_adapter.h
• runtime/src/hle/input/pad.cpp
• runtime/src/main.cpp
• runtime/src/settings_overlay.cpp
• runtime/src/wup028_adapter.cpp

💤 Files with no reviewable changes (6)

• .gitignore
• aurora-main/include/dolphin/pad.h
• runtime/include/wup028_adapter.h
• runtime/src/wup028_adapter.cpp
• runtime/src/main.cpp
• runtime/include/runtime_config.h

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes WUP-028 adapter support, simplifies PAD input state handling, updates controller index assignment, removes related Windows libraries, and changes build output ignore rules.

Changes

Controller input changes

Layer / File(s)	Summary
PAD input blocking contract aurora-main/include/dolphin/pad.h, aurora-main/lib/dolphin/pad/pad.cpp	The PAD blocking flag now uses direct boolean access. The public PADIsInputBlocked accessor is removed.
WUP-028 runtime removal runtime/include/runtime_config.h, runtime/include/wup028_adapter.h, runtime/src/wup028_adapter.cpp, runtime/src/hle/input/pad.cpp, runtime/src/main.cpp, runtime/src/settings_overlay.cpp, runtime/cmake/PublicProducts.cmake	WUP-028 configuration, implementation, startup and shutdown calls, adapter UI, adapter input handling, and Windows library links are removed.
Controller index assignment aurora-main/lib/input.cpp	Controller assignment preserves valid SDL or cached indices and selects an available port, using configured ports as fallback.

Repository build cleanup

Layer / File(s)	Summary
Build output tracking .gitignore	The ignore rules for three build output directories are removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 2d88f

The revert is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant RuntimeStartup
  participant PADInitHLE
  participant PADReadHLE
  participant PADLibrary
  RuntimeStartup->>PADInitHLE: initialize HLE pad handling
  PADInitHLE->>PADLibrary: invoke PADInit
  PADReadHLE->>PADLibrary: invoke PADRead
  PADReadHLE->>PADLibrary: invoke PADControlMotor

Loading

Suggested reviewers: galaxisbeast

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 4 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies this pull request as a revert of merge pull request #42, which matches the stated objective and the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 4 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-42

---

_{Comment @coderabbitai help to get the list of available commands.}

[patchzyy]

not merging yet, just making the PR, will check if SDL3 driver is built with libusb support enabled on windows when i get back home

[patchzyy]

Windows vendored SDL3 has no libusb so the driver stays until that changes. Reverting i believe cause a regression.