fix(gen-zig): a module-scoped type maps like its bare name (owner exception, #5980) - #6599
Merged
Merged
Conversation
Closes #6533 A spliced struct kept gf16::GF16 as gf16.GF16, which the generated Zig does not declare. The Zig type mapper now maps a module-scoped type like its bare name (gf16::GF16 -> u16). specs/compiler/zig_scoped_type.t27 is the regression spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #6533 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #6533 Regenerated on the Railway t27c lab (tri seals drift --fix, sync-twins); check_seal_currency and check_seal_coverage pass there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
added
the
owner-approved-foreign
Contributor
6 tasks
This was referenced Oct 5, 2026
Merged
Contributor
PR DashboardGenerated at: 2026-10-05 22:04:11 UTC
Summary
Seal Status
|
Contributor
PR DashboardGenerated at: 2026-10-05 22:18:50 UTC
Summary
Seal Status
|
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6533
What
A struct spliced in by
usekept a module-scoped type,gf16::GF16, asgf16.GF16. The generated Zig never declares that name, so the file did not compile. The Zig type mapper now maps a module-scoped type the same way as its bare name (gf16::GF16->u16).specs/compiler/zig_scoped_type.t27is the regression spec.Owner exception
This PR edits hand-written Rust (
bootstrap/src/compiler.rs), which the only-t27 rule forbids. The owner approved it on 2026-10-05, relayed by the coordinator ("fix it and do not stop, do what is best"), with the labelowner-approved-foreign. The debt is #5980 (t27core self-host). This PR does not changetools/policy/foreign-exceptions.txt. The entriesbootstrap/src/compiler.rsandbootstrap/tests/bare_semicolon_zig.rsare already on master from #6579. They stay for the remaining gen-zig classes the owner listed (genericTundeclared,math.*,expected ',' after field). When those land, or are dropped, the owner should remove the entries.File classification
bootstrap/src/compiler.rsbootstrap/stage0/FROZEN_HASHspecs/compiler/zig_scoped_type.t27.trinity/seals/*.json(16)tri seals drift --fix,tri seals sync-twins)docs/now/2026-10-06-gen-zig-scoped-type.mdLab numbers (t27c reference: gen-zig + zig test over specs/, Railway t27c lab)
ml/transformer/multi_head_attention.t27gets past this error and stops at its next one, so it stays blocked.Seals
Seals were regenerated on the lab. On the lab,
check_seal_currencypasses andcheck_seal_coveragereports OK (1454 seals, 1310 hold, 144 known-broken).CI notes
GateScarabtype conflict (master red after the queen batch merge (a4e68bae): 9 stale sort seals, insertion_sort tests fail, GateScarab type conflict #6609). This PR leaves those seals alone, so its coverage failure is master's. A drift pass at b146260 found nothing else.The expected failures match master: test-ratchet (
the_dead_code_census_names_what_it_skippedandcorpus_classifier_matches_lean_completeness), spec-guards (ring-096-rustDRIFTED, #6553), duplicate-bodies, fpga-conformance, and build-and-test (cargo install wasm-objdump).🤖 Generated with Claude Code