Repository navigation
Fail the offline bundle build when a dependency download fails (#182) - #197
Merged
Merged
Conversation
build_bundle.sh ran `apt-get download $DEPS ... || true`, so a failed download was ignored. The only check after it covered the four top-level packages, so a bundle missing a dependency still reported success and failed later on the offline VM. - Skip virtual packages (Candidate: (none)) because they have nothing to download. - Download the remaining closure without `|| true`, so set -e stops the build. Verified on Ubuntu 24.04 (apt index reachable from the sandbox): - Real closure, 114 packages: download exit 0, 114 .deb files. - Small list with one real package, one virtual package and one bogus name: the virtual package is skipped and the bogus name exits 100. - Clean small list: exit 0. - Old code with a bogus dependency: exit 0 with no .deb for it. Not run: the full build_bundle.sh (npm, pip, frontend steps). Needs a run on the Ubuntu 24.04 WSL (runbook Phase A). Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6Wqk7v8qnw9h29hpqnnv
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #182.
What changes
scripts/offline/build_bundle.shno longer hides dependency download failures.apt-get download $DEPS ... || true. A failed download was ignored, and the only check afterwards covered four top-level packages. A bundle missing a dependency still reported success and failed later on the offline VM.Candidate: (none)) are skipped. The real closure is downloaded without|| true, soset -estops the build on any failure.Checks run
.debfiles. Run on Ubuntu 24.04 with the apt index reachable from the sandbox..debfor it, which reproduces the defect.bash -n scripts/offline/build_bundle.shpasses.Not run
build_bundle.sh, including thenpm ci, pip and frontend steps. This needs a run on the Ubuntu 24.04 WSL (runbook Phase A) before RV-S8: Offline bundle download suppresses failures with || true #182 can close.Generated by Claude Code