Skip to content

RV-S8: Offline bundle download suppresses failures with || true #182

Closed

Description

@amar-python

What happened

External repo review at commit c7bebd1 reproduced: scripts/offline/build_bundle.sh L37–49 suppresses all apt-get download failures with || true; the following check verifies only four top-level packages. A stubbed failed dependency download still produced success with that dependency absent.

Why this matters

Sub-issue of #60. The clean-VM dry run (due 15 Nov) depends on the bundle containing every dependency it claims. The current script cannot be trusted to produce a complete bundle, so an evidence run against the current script would not actually prove the install works offline — it would only prove the install works when the missing deps happen not to be exercised.

Proposed

  1. Remove || true from the apt-get download loop.
  2. After download, verify the complete dependency closure (every package the smoke test's install.sh invokes must be present).
  3. Fail the script loudly on any missing package.
  4. Rebuild the bundle on a current main after fix; new SHA-256 replaces the one on 2026-11-15: ship air-gapped install procedure or keep interim wording #60.

Done when

Reference

Tracker row G41. Repo review finding RV-S8. Blocks #60 clean-VM dry run evidence acceptance.

Activity

  1. added a commit that references this issue on Nov 4, 2026
  2. amar-python commented on Nov 4, 2026

    @amar-python
    OwnerAuthor

    Ubuntu 24.04 (WSL) build run of scripts/offline/build_bundle.sh at commit 74c248f (merge of PR #197). The run reached the final step and printed:

    Bundle: /home/user/PostgreDataMigrationAppWithCSVLoader/dist/offline-bundle-74c248f.tar.gz (143M)

    Checksum check: sha256sum -c offline-bundle-74c248f.tar.gz.sha256 returned offline-bundle-74c248f.tar.gz: OK.

    Not yet verified: scripts/offline/install.sh on a clean Ubuntu 24.04 VM, and smoke_test.sh. Those are the evidence #60 needs. This comment does not close #182.


    Generated by Claude Code

  3. amar-python commented on Nov 7, 2026

    @amar-python
    OwnerAuthor

    Already fixed on main in commit b7006a7 ("Fail the offline bundle build when a dependency download fails"). The || true was removed and replaced with proper error propagation and a virtual-package filter.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions