You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
RV-S8: Offline bundle download suppresses failures with || true #182
External repo review at commit c7bebd1 reproduced: scripts/offline/build_bundle.sh L37–49 suppresses all apt-get download failures with || true; the following check verifies only four top-level packages. A stubbed failed dependency download still produced success with that dependency absent.
Why this matters
Sub-issue of #60. The clean-VM dry run (due 15 Nov) depends on the bundle containing every dependency it claims. The current script cannot be trusted to produce a complete bundle, so an evidence run against the current script would not actually prove the install works offline — it would only prove the install works when the missing deps happen not to be exercised.
Proposed
Remove || true from the apt-get download loop.
After download, verify the complete dependency closure (every package the smoke test's install.sh invokes must be present).
Checksum check: sha256sum -c offline-bundle-74c248f.tar.gz.sha256 returned offline-bundle-74c248f.tar.gz: OK.
Not yet verified: scripts/offline/install.sh on a clean Ubuntu 24.04 VM, and smoke_test.sh. Those are the evidence #60 needs. This comment does not close #182.
Already fixed on main in commit b7006a7 ("Fail the offline bundle build when a dependency download fails"). The || true was removed and replaced with proper error propagation and a virtual-package filter.
Activity
Merge pull request #197 from amar-python/fix/182-bundle-download-fail…
amar-python commentedon Nov 4, 2026
Ubuntu 24.04 (WSL) build run of
scripts/offline/build_bundle.shat commit 74c248f (merge of PR #197). The run reached the final step and printed:Bundle: /home/user/PostgreDataMigrationAppWithCSVLoader/dist/offline-bundle-74c248f.tar.gz (143M)
Checksum check:
sha256sum -c offline-bundle-74c248f.tar.gz.sha256returnedoffline-bundle-74c248f.tar.gz: OK.Not yet verified:
scripts/offline/install.shon a clean Ubuntu 24.04 VM, andsmoke_test.sh. Those are the evidence #60 needs. This comment does not close #182.Generated by Claude Code
amar-python commentedon Nov 7, 2026
Already fixed on main in commit b7006a7 ("Fail the offline bundle build when a dependency download fails"). The
|| truewas removed and replaced with proper error propagation and a virtual-package filter.Generated by Claude Code