Skip to content

Fail the offline bundle build when a dependency download fails (#182) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amar-python merged 1 commit into from
Nov 4, 2026
Merged

Fail the offline bundle build when a dependency download fails (#182) #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/offline/build_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@ PKGS="postgresql-16 postgresql-client-16 python3.12-venv nodejs"
# Ubuntu 24.04 already has; apt skips those on install. Prune if size matters.
DEPS=$(apt-cache depends --recurse --no-recommends --no-suggests --no-conflicts \
--no-breaks --no-replaces --no-enhances $PKGS | grep '^[a-z0-9]' | sort -u)
( cd "$OUT/debs" && apt-get download $DEPS >/dev/null 2>&1 || true )
# Virtual packages have no candidate and nothing to download, so skip them. Any real
# package that fails to download stops the build; the old `|| true` let a partial bundle pass (#182).
REAL=()
for p in $DEPS; do
apt-cache policy "$p" | grep -q 'Candidate: (none)' || REAL+=("$p")
done
( cd "$OUT/debs" && apt-get download "${REAL[@]}" >/dev/null )
for p in $PKGS; do ls "$OUT/debs/${p}_"*.deb >/dev/null || { echo "missing deb: $p" >&2; exit 1; }; done
( cd "$OUT/debs" && apt-ftparchive packages . > Packages ) # local apt repository index

Expand Down
Loading