Skip to content

Track PR #197 checks that completed after merge: integration (postgres service) and python-validator-tests #198

Open

Description

@amar-python

Found on 4 Nov 2026 when PR #197 (#182) merged.

PR #197 merged at 11:43:52Z. Two of its checks had not finished at that point, so they ran after the merge:

  • integration (postgres service): completed success at 11:45:08Z
  • python-validator-tests: completed success at 11:44:55Z

The free-tier (unit, lint, health, evals-p) check had already passed before the merge.

Proposed

Keep this issue open as the record that the two checks ran after the merge, and that the merge was not gated on them. Next time, merge after the required checks complete.

Done when

  • Repo branch protection is checked, and the list of required checks is recorded here.
  • Either the two checks are added to the required set, or a decision is recorded that they stay advisory.

Generated by Claude Code

Activity

  1. amar-python commented on Nov 9, 2026

    @amar-python
    OwnerAuthor

    Findings from checking branch protection on main (read-only, 2026-11-09). Nothing was changed.

    Live state: main is not protected

    • GET /branches/main/protection returns 404 Branch not protected.
    • GET /branches/main: protected: false, required_status_checks.contexts: [], enforcement_level: off.
    • GET /rules/branches/main returns no rules.
    • The only ruleset, ConsolidatedPostgreDataMigrationApp (id 20365935, created 2026-08-04), has enforcement: disabled.

    Required checks currently enforced: none.

    This contradicts DECISIONS/2026-11-02-main-branch-protection.md

    That record says protection was applied on 2026-11-02 with three required checks (python-validator-tests, free-tier (unit, lint, health, evals-p), integration (postgres service)), strict: true, enforce_admins: true, a PR required with 0 approvals, and no force-push or deletion. claude/project-status.md says it was "verified live". It is not live now. I could not tell from the API whether it was removed or never persisted.

    Why PR #197 merged before its checks finished

    Nothing required them. Check-run timings on PR #197's head (b7006a7), against the merge at 2026-11-04T11:43:52Z:

    Check Completed Result
    free-tier (unit, lint, health, evals-p) 11:43:24Z success
    python-validator-tests 11:44:55Z success
    integration (postgres service) 11:45:08Z success

    Remaining to close this issue

    1. Re-apply the 2 Nov decision (command below), or record a decision that the checks stay advisory.
    2. Record the resulting required-check list here.

    Note for whoever applies it: with enforce_admins and strict, PRs must be up to date with main and pass all three checks before merging, including the owner's.

    gh api --method PUT repos/amar-python/PostgreDataMigrationAppWithCSVLoader/branches/main/protection --input - <<'JSON'
    {"required_status_checks":{"strict":true,"contexts":["python-validator-tests","free-tier (unit, lint, health, evals-p)","integration (postgres service)"]},"enforce_admins":true,"required_pull_request_reviews":{"required_approving_review_count":0},"restrictions":null,"allow_force_pushes":false,"allow_deletions":false}
    JSON
    

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions