Repository navigation
fix(social): self-test follow-ups (#161 grant leak, waiting-room code, approval flash, remote settings, Talk through wrap) - #163
Conversation
…te settings Product self-test on main 7a7225f: five owner-facing bugs. - ThinkFlowLab#161 / ThinkFlowLab#138: accepting an invite no longer lists the joiner's Chief on the inviter's Friends list. Outgoing grants win over inbound backfill; a fresh-install regression test covers invite accept. - ThinkFlowLab#158: the face waiting room shows the 6-digit code; setup copy no longer says there is no preview. - ThinkFlowLab#159: a held owner face line shows the human text from the trusted sender, never a flash of the FLYBOT-FACE-HUMAN envelope. The card stays until Approve / Always approve / Reject unless face Auto-send is on. - ThinkFlowLab#160: a friend's Bot settings is a remote surface (Auto-send and Remove this Bot), not the local editor. Remove closes the overlay. - ThinkFlowLab#162: Add friend "Talk through" stays on one line. ARCH_DOCS_BASE=upstream/main npm run verify passes (one known tasks.test.js flake retried green). Fixes ThinkFlowLab#161, Fixes ThinkFlowLab#158, Fixes ThinkFlowLab#159, Fixes ThinkFlowLab#160, Fixes ThinkFlowLab#162 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 843b477ca5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const raw = draftText(value) | ||
| const human = parseFaceHuman(raw) | ||
| return human ? draftText(human.text) : raw |
There was a problem hiding this comment.
When a held owner line is longer than roughly 750 characters, draftText truncates the envelope JSON before parseFaceHuman; when it contains { or }, the parser also treats braces inside the JSON string as structure. In either case this helper falls back to the raw envelope and the new client shownHoldText reduces it to an empty prefix, so the approval card omits the draft and the owner must approve or reject unseen content. Parse the complete envelope with a JSON-aware parser, then apply the 800-character cap to the extracted text and use the same logic client-side.
Useful? React with 👍 / 👎.
Fixes five bugs from the product self-test on main
7a7225f.FLYBOT-FACE-HUMANto the human line from the trusted sender; no raw-envelope flash. Auto-approve only when face Auto-send is on.nowrap).ARCH_DOCS_BASE=upstream/main npm run verifypasses.Fixes #161, Fixes #158, Fixes #159, Fixes #160, Fixes #162