Repository navigation
fix(coverage): apply reviewed terminal and carrier corrections to main - #432
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28d19c6de1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Some carriers are live in production but not in the public default set. Contact Terminal49 to enable them on your account. | ||
|
|
||
| See [account-enabled carriers](/coverage/ocean-carriers#account-enabled-carriers) for Seaboard Marine (`SMLU`) and Trailer Bridge (`TRBR`). | ||
| See [account-enabled carriers](/coverage/ocean-carriers#account-enabled-carriers) for Trailer Bridge (`TRBR`). |
There was a problem hiding this comment.
Add these roster corrections to the coverage changelog
This updates the current roster by making SMLU public and, through the accompanying overrides, removing SAFM, SEJJ, and SQQY, but the coverage changelog still says SMLU is account-enabled and SeaLead was added, with no later correction. Because that page promises an audit trail of additions and removals, readers cannot determine when or why the current roster diverged; add a dated correction covering the three removals and the SMLU access change.
AGENTS.md reference: docs/AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
| const declaredFeatures = identifiers.smdgCode | ||
| ? terminalCapabilities[terminal.locode + ':' + identifiers.smdgCode] | ||
| ?.features | ||
| : undefined; |
There was a problem hiding this comment.
Unmatched declarations disappear silently
importHex silently skips a terminal declaration when its key matches no verified terminal. A mistyped key or a later identifier change can drop reviewed coverage while the import and --check both succeed. The separate canonical test catches this only after the import has written its outputs.
As a non-blocking improvement, check that every declaration matches exactly one terminal before writing files.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tools/generate-coverage.mjs
Line: 301-304
Comment:
**Unmatched declarations disappear silently**
`importHex` silently skips a terminal declaration when its key matches no verified terminal. A mistyped key or a later identifier change can drop reviewed coverage while the import and `--check` both succeed. The separate canonical test catches this only after the import has written its outputs.
As a non-blocking improvement, check that every declaration matches exactly one terminal before writing files.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Why
The default branch still lists three disabled shipping lines, marks Seaboard Marine as account-only without container-number tracking, and shows unknown LFD/discharge coverage for three Australian DP World terminals. Apply the reviewed corrections from #427 and #428, whose merges went to parent branches rather than main.
What changed
Scope
These are the existing reviewed data proposals, with no new source collection or capability assessment. The resulting roster contains 138 terminals, 35 shipping lines and six rail carriers. Dates and rail coverage remain unchanged. The source refresh pipeline is still not operational.
Blast Radius
Public coverage data, generated tables and downloads change together. The canonical dataset matches the reviewed parent-branch merge exactly. Declaration evidence conditions remain those reviewed in #427/#428; this PR does not establish live tracking or automatic source refresh.
Verification
npm run test:coverage: 45 tests and both export drift checks pass after regeneration.git diff --checkpasses; focused lint has no errors, with existing generator-validation warnings.Need help on this PR? Tag
@codesmith-botwith what you need.The PR appears safe to merge, with a non-blocking improvement to catch unmatched terminal declarations during import.
Fix with agent prompt
Summary
Applies the reviewed coverage corrections across the dataset, public tables, and downloads.
No blocking issue was found. One non-blocking improvement would make imports reject terminal declarations that match no terminal.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Traffic observations] --> D[Coverage import] B[Reviewed terminal capabilities] --> D C[Reviewed carrier overrides] --> D D --> E[Canonical coverage] E --> F[Public tables and explorers] E --> G[JSON and CSV downloads]Reviews (1) · Last reviewed commit: "test(coverage): resolve published snapsh..." · Reviewed by Greptile