Skip to content

fix(coverage): apply reviewed terminal and carrier corrections to main - #432

Merged
dodeja merged 3 commits into
mainfrom
codex/coverage-proposals-to-main
Oct 14, 2026
Merged

dodeja merged 3 commits into
mainfrom
codex/coverage-proposals-to-main

Conversation

@dodeja

@dodeja dodeja commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Why

The default branch still lists three disabled shipping lines, marks Seaboard Marine as account-only without container-number tracking, and shows unknown LFD/discharge coverage for three Australian DP World terminals. Apply the reviewed corrections from #427 and #428, whose merges went to parent branches rather than main.

What changed

  • Declare terminal LFD and vessel discharge for DP World Brisbane, Fremantle and Sydney using exact port/SMDG identities.
  • Remove SAFM, SEJJ and SQQY; list SMLU publicly with container-number lookup available. Preserve all other returned-field assessments.
  • Preserve reviewed capabilities and admission state across later imports. Update the local deployed-check fixtures to resolve published raw snapshot URLs.

Scope

These are the existing reviewed data proposals, with no new source collection or capability assessment. The resulting roster contains 138 terminals, 35 shipping lines and six rail carriers. Dates and rail coverage remain unchanged. The source refresh pipeline is still not operational.

Blast Radius

Public coverage data, generated tables and downloads change together. The canonical dataset matches the reviewed parent-branch merge exactly. Declaration evidence conditions remain those reviewed in #427/#428; this PR does not establish live tracking or automatic source refresh.

Verification

  • npm run test:coverage: 45 tests and both export drift checks pass after regeneration.
  • Exact comparison confirms six terminal status changes, three carrier removals, and only SMLU access/container admission changes among retained carriers.
  • Independent source/data review completed. git diff --check passes; focused lint has no errors, with existing generator-validation warnings.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking improvement to catch unmatched terminal declarations during import.

Fix All in CodexFindings

  1. P2 Unmatched declarations disappear silently ▶
Fix with agent prompt
### Issue 1
tools/generate-coverage.mjs:301-304
`importHex` silently skips a terminal declaration when its key matches no verified terminal. A mistyped key or a later identifier change can drop reviewed coverage while the import and `--check` both succeed. The separate canonical test catches this only after the import has written its outputs.

As a non-blocking improvement, check that every declaration matches exactly one terminal before writing files.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Applies the reviewed coverage corrections across the dataset, public tables, and downloads.

  • Three Australian terminals show their reviewed event coverage.
  • The shipping-line roster drops three disabled carriers and opens SMLU publicly.
  • Deployed coverage fixtures follow the links published on each page.

No blocking issue was found. One non-blocking improvement would make imports reject terminal declarations that match no terminal.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Traffic observations] --> D[Coverage import]
  B[Reviewed terminal capabilities] --> D
  C[Reviewed carrier overrides] --> D
  D --> E[Canonical coverage]
  E --> F[Public tables and explorers]
  E --> G[JSON and CSV downloads]
Loading

Reviews (1) · Last reviewed commit: "test(coverage): resolve published snapsh..." · Reviewed by Greptile

@mintlify

mintlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
terminal49 🟢 Ready View Preview Oct 14, 2026, 5:18 PM

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Oct 14, 2026 5:18pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T17:20:16.741595Z 28d19c6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28d19c6de1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/coverage/home.mdx
Some carriers are live in production but not in the public default set. Contact Terminal49 to enable them on your account.

See [account-enabled carriers](/coverage/ocean-carriers#account-enabled-carriers) for Seaboard Marine (`SMLU`) and Trailer Bridge (`TRBR`).
See [account-enabled carriers](/coverage/ocean-carriers#account-enabled-carriers) for Trailer Bridge (`TRBR`).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add these roster corrections to the coverage changelog

This updates the current roster by making SMLU public and, through the accompanying overrides, removing SAFM, SEJJ, and SQQY, but the coverage changelog still says SMLU is account-enabled and SeaLead was added, with no later correction. Because that page promises an audit trail of additions and removals, readers cannot determine when or why the current roster diverged; add a dated correction covering the three removals and the SMLU access change.

AGENTS.md reference: docs/AGENTS.md:L20-L20

Useful? React with 👍 / 👎.

Comment on lines +301 to +304
const declaredFeatures = identifiers.smdgCode
? terminalCapabilities[terminal.locode + ':' + identifiers.smdgCode]
?.features
: undefined;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unmatched declarations disappear silently

importHex silently skips a terminal declaration when its key matches no verified terminal. A mistyped key or a later identifier change can drop reviewed coverage while the import and --check both succeed. The separate canonical test catches this only after the import has written its outputs.

As a non-blocking improvement, check that every declaration matches exactly one terminal before writing files.

Prompt To Fix With AI
This is a comment left during a code review.
Path: tools/generate-coverage.mjs
Line: 301-304

Comment:
**Unmatched declarations disappear silently**

`importHex` silently skips a terminal declaration when its key matches no verified terminal. A mistyped key or a later identifier change can drop reviewed coverage while the import and `--check` both succeed. The separate canonical test catches this only after the import has written its outputs.

As a non-blocking improvement, check that every declaration matches exactly one terminal before writing files.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex Fix in Claude Code

@dodeja
dodeja merged commit b78f3aa into main Oct 14, 2026
27 of 28 checks passed

This branch was successfully deployed

2 active deployments
Preview — 28d19c6d Deployed Oct 14, 2026 by vercel[bot]
staging - docs — 28d19c6d Deployed Oct 14, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant