Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1ec9dee to
9ae8cc8
Compare
…ty (#428) * feat: preserve reviewed shipping-line state during coverage imports * docs: propose reviewed current shipping-line coverage
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15322de6e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "SAFM": { | ||
| "enabled": false | ||
| }, |
There was a problem hiding this comment.
These overrides remove Safmarine, Sealand Europe, and SeaLead from the published roster, while the same change also makes Seaboard Marine public, but docs/coverage/changelog.mdx still stops at October 9 and presents its August roster as the latest recorded carrier state. Because that page promises an auditable history of additions and removals, readers cannot determine when or why these four availability changes occurred; add a dated entry covering the removals and Seaboard’s access change.
AGENTS.md reference: docs/AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "SAFM": { | ||
| "enabled": false | ||
| }, | ||
| "SEJJ": { | ||
| "enabled": false | ||
| }, | ||
| "SQQY": { | ||
| "enabled": false | ||
| }, | ||
| "SMLU": { | ||
| "access": "public", | ||
| "trackingIdentifiers": { | ||
| "containerNumber": true |
There was a problem hiding this comment.
These overrides remove SAFM, SEJJ, and SQQY and move SMLU into the public set, but the coverage changelog has no entry for them. That page promises to record additions and removals so readers can audit coverage over time. Add a dated entry for these changes; keep the older entries unchanged.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tools/data/shipping-line-overrides.json
Line: 2-14
Comment:
**Carrier changes go unrecorded**
These overrides remove `SAFM`, `SEJJ`, and `SQQY` and move `SMLU` into the public set, but the coverage changelog has no entry for them. That page promises to record additions and removals so readers can audit coverage over time. Add a dated entry for these changes; keep the older entries unchanged.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comments Outside DiffThese findings could not be posted inline.
|
This branch was successfully deployed
1 participant
Three Australian DP World terminals currently show unknown terminal LFD and vessel-discharge coverage. This draft proposes six reviewed capability declarations and preserves them independently of traffic-based classifications during later refreshes.
Changes only terminal LFD and vessel discharge for Brisbane (AUBNE/DPBNE), Fremantle (AUFRE/CONFR), and Sydney (AUSYD/CTLPB). All other coverage values, identities, and dates are unchanged. Declarations match exact port and SMDG identifiers; they cannot transfer between similarly named terminals or the same code at another port.
Evidence review checked field implementations, active configuration, and recent terminal-source observations. This is a draft for final data-owner review. Integration-level attribution and deployed revision still need confirmation before automatic publication. Other proposed capabilities and semantic conflicts remain pending.
Depends on #426 for repaired public downloads.
Validation: 30 coverage tests and both generated-artifact drift checks pass. Tests cover conflicting/low-volume observations, missing/malformed declarations, identifier isolation, and canonical agreement. Independent implementation and data-evidence reviews completed. Internal query, traffic, and implementation details are kept out of this public repository.
Need help on this PR? Tag
@codesmith-botwith what you need.The PR appears safe to merge, with non-blocking gaps in the carrier changelog and canonical carrier tests.
Fix with agent prompt
Summary
Adds persistent declarations for terminal LFD and vessel discharge at three Australian DP World terminals. Imports apply them using exact port and SMDG identifiers.
dodejaacknowledges that final data-owner review, source attribution, and deployed revision confirmation remain pending before automatic publication.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Historical terminal and carrier registry] --> C[Coverage import] B[Fresh observations] --> C I[Verified terminal identifiers] --> C T[Reviewed terminal capabilities] --> C S[Reviewed carrier overrides] --> C C --> D[Canonical coverage] D --> E[JSON and CSV downloads] D --> F[Coverage pages and explorer data]Reviews (1) · Last reviewed commit: "fix: reconcile shipping-line coverage wi..." · Reviewed by Greptile