Skip to content

docs(coverage): list Seaboard Marine (SMLU) as public carrier - #429

Closed
claude[bot] wants to merge 2 commits into
mainfrom
claude/coverage-seaboard-public
Closed

claude[bot] wants to merge 2 commits into
mainfrom
claude/coverage-seaboard-public

Conversation

@claude

@claude claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Namita Dodeja · Slack thread

Before: Seaboard Marine (SMLU) appears only under "Account-enabled carriers" on the ocean carriers coverage page, with container number tracking marked as not supported.

After: Seaboard Marine appears in the main public table of the ocean carriers coverage page, trackable by bill of lading, booking, or container number.

This moves SMLU from access: account to access: public and marks container number tracking as supported, so the public set goes from 36 to 37 shipping lines and the account-enabled set from 2 to 1 (Trailer Bridge).

How: There is a generator (tools/generate-coverage.mjs), so I did not hand-edit the generated files. I changed the SMLU entry in the canonical docs/data/coverage/coverage.json and in the identity file docs/snippets/data-sources/coverage-data.mdx (so a later --importHex run does not revert it), then ran node tools/generate-coverage.mjs. That regenerated carrier-feature-data.mdx, shipping-lines.{json,csv,mdx}, and the agent section of ocean-carriers.mdx. Hand-edited: coverage/changelog.mdx (new 2026-10-14 entry, includes "enter the master BL without the SMLU prefix"), the Seaboard mention in the account-enabled paragraph of coverage/home.mdx (main's #426 already removed the hard-coded count from the ocean carrier card, so merging it left only that mention to change), and the public/account counts in tools/generate-coverage.test.mjs (36 to 37, 2 to 1). No other SMLU features were changed: all other attributes stay unknown (no POD ETA or other attribute coverage is claimed). node tools/generate-coverage.mjs --check and the coverage tests pass. After merging main (#426, #430) the verify-deployed-coverage tests show 5 failures that also occur on a clean origin/main checkout in this sandbox, so they are not caused by this PR.

Matthew Turner (engineering) confirmed in Slack on 2026-10-14 that the integration is live in production for all accounts and trackable by BL or container; this isn't verifiable from the repo (the staging migration registers shipping_line.smlu.mobile with default: false, weight: 0.0, so production config is database state).

Not changed: the carrierCoverageGeneratedOn export date (2026-08-14) and the "36 ocean carriers, plus 2 more enabled on request, as of 14 August 2026" lines on the docs/migrate/*.mdx pages, which are dated statements.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GvpwGFSoR7Ycun5PNufyGz


Generated by Claude Code


&lt;source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"&gt;&lt;source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"&gt;&lt;img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"&gt; <a href="'''https://backend.blacksmith.sh/track/enable-autofix?expires=1794537708&installation_model_id=18852&pr_number=429&ref=codesmith_pr_footer&repository=Terminal49%2FAPI&return_to=https%3A%2F%2Fgithub.com%2FTerminal49%2FAPI%2Fpull%2F429&signature=68bb17dd3ad1a154b36ce9ede6b78f738408fb884325e63ee30a57a80ad4395b"&gt;&lt;picture&gt;&lt;source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"&gt;&lt;source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"&gt;&lt;img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"&gt;```
Need help on this PR? Tag @codesmith-bot with what you need.

@mintlify

mintlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
terminal49 🟢 Ready View Preview Oct 14, 2026, 4:45 PM

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Oct 14, 2026 4:45pm UTC

Request Review

@claude

claude Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

The failing check "MCP preview 2026-07-28" is not caused by this PR. It fails at packages/mcp/eval/tools.eval.ts:138 with "fixture discovery found no shipmentId, containerId, containerNumber on this account", meaning the account behind the MCP_EVAL_TOKEN secret has no tracked shipments. The same job and message are red on main (run 38483636966, 2026-10-13) and on other branches, and this PR touches only docs, coverage data and tools/generate-coverage.test.mjs. "Coverage generators and drift checks" passes. I'm not changing anything here; the fix is to point the secret at an account with tracked data (or set MCP_EVAL_ALLOW_SPARSE=1, which skips the detail-tool cases). I couldn't re-run the job from this session.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GvpwGFSoR7Ycun5PNufyGz
@claude

claude Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

"Coverage generators and drift checks" is red on this head but not because of this PR's data. npm run test:coverage fails 5 of 38 tests, all in tools/verify-deployed-coverage.test.mjs (lines 54, 64, 78, 185, 196), with ENOENT ... docs//Terminal49/API/maindata/coverage/inland-rail-terminals.csv. The test fixture() strips /docs/ from the URL path (line 14), which mangles the raw.githubusercontent.com/Terminal49/API/main/docs/data/coverage/<file> download links that #426 put into the docs. main fails the same job since #430 (run 38600362972, main 90b90c6), and this PR touches none of the verifier files. On this branch node tools/generate-coverage.mjs --check, node tools/generate-rail-terminals.mjs --check and the generator tests pass. I'm not changing the verifier here. The fix is in main: make fixture() handle raw.githubusercontent URLs (or change how the verifier maps those URLs to local files). Once that lands I'll merge main into this branch and re-check. Separately, "MCP preview 2026-07-28" is the unrelated eval-fixture failure described above.


Generated by Claude Code

@dodeja
dodeja marked this pull request as ready for review October 14, 2026 17:09
@greptile-apps

greptile-apps Bot commented Oct 14, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T17:11:48.931821Z 8d7aab3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d7aab3e19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"scac": "SMLU",
"alternativeScacs": [],
"access": "account",
"access": "public",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep SMLU gated until production access is confirmed

This value drives the generated public carrier table and downloads, but the commit's own verification notes say all-account production availability is still unconfirmed and that the last observed integration was registered with default: false and zero weight. Publishing it as public now can therefore tell customers they can submit SMLU tracking requests when their accounts may not have a usable integration; keep it account-enabled until production configuration is confirmed, or add checked-in evidence that it is enabled by default.

AGENTS.md reference: docs/AGENTS.md:L20-L20

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this as is. The concern is fair, since the repo alone can't show it: the smlu.mobile migration on staging registers the integration with default: false and weight: 0.0, and production state lives in the database. But Matthew Turner (engineering) said in Slack on 2026-10-14 that the Seaboard mobile integration is "already in production for all accounts" and that it can be tracked by BL or container, which is what this change reflects. The requester has marked the PR ready on that basis. If that turns out to be wrong, reverting is a one-row change to the SMLU entry in coverage.json plus a regenerate (access back to account, containerNumber back to unsupported).


Generated by Claude Code

@claude

claude Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #432 (merged 2026-10-14T17:22Z) already lists Seaboard Marine (SMLU) as a public carrier with container-number lookup, and the live coverage page shows it. This PR's 37/1 counts no longer match main and it conflicts with it. Not merging anything further here; if a changelog entry for the Seaboard change is wanted, it can be a small separate PR.


Generated by Claude Code

This branch was successfully deployed

2 active deployments
Preview — 8d7aab3e Deployed Oct 14, 2026 by vercel[bot]
staging - docs — 8d7aab3e Deployed Oct 14, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant