Repository navigation
docs(coverage): list Seaboard Marine (SMLU) as public carrier - #429
claude[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvpwGFSoR7Ycun5PNufyGz
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The failing check "MCP preview 2026-07-28" is not caused by this PR. It fails at Generated by Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvpwGFSoR7Ycun5PNufyGz
|
"Coverage generators and drift checks" is red on this head but not because of this PR's data. Generated by Claude Code |
|
PR author is in the excluded authors list. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d7aab3e19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "scac": "SMLU", | ||
| "alternativeScacs": [], | ||
| "access": "account", | ||
| "access": "public", |
There was a problem hiding this comment.
Keep SMLU gated until production access is confirmed
This value drives the generated public carrier table and downloads, but the commit's own verification notes say all-account production availability is still unconfirmed and that the last observed integration was registered with default: false and zero weight. Publishing it as public now can therefore tell customers they can submit SMLU tracking requests when their accounts may not have a usable integration; keep it account-enabled until production configuration is confirmed, or add checked-in evidence that it is enabled by default.
AGENTS.md reference: docs/AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Leaving this as is. The concern is fair, since the repo alone can't show it: the smlu.mobile migration on staging registers the integration with default: false and weight: 0.0, and production state lives in the database. But Matthew Turner (engineering) said in Slack on 2026-10-14 that the Seaboard mobile integration is "already in production for all accounts" and that it can be tracked by BL or container, which is what this change reflects. The requester has marked the PR ready on that basis. If that turns out to be wrong, reverting is a one-row change to the SMLU entry in coverage.json plus a regenerate (access back to account, containerNumber back to unsupported).
Generated by Claude Code
|
Closing as superseded: #432 (merged 2026-10-14T17:22Z) already lists Seaboard Marine (SMLU) as a public carrier with container-number lookup, and the live coverage page shows it. This PR's 37/1 counts no longer match Generated by Claude Code |
Requested by Namita Dodeja · Slack thread
Before: Seaboard Marine (
SMLU) appears only under "Account-enabled carriers" on the ocean carriers coverage page, with container number tracking marked as not supported.After: Seaboard Marine appears in the main public table of the ocean carriers coverage page, trackable by bill of lading, booking, or container number.
This moves SMLU from
access: accounttoaccess: publicand marks container number tracking as supported, so the public set goes from 36 to 37 shipping lines and the account-enabled set from 2 to 1 (Trailer Bridge).How: There is a generator (
tools/generate-coverage.mjs), so I did not hand-edit the generated files. I changed the SMLU entry in the canonicaldocs/data/coverage/coverage.jsonand in the identity filedocs/snippets/data-sources/coverage-data.mdx(so a later--importHexrun does not revert it), then rannode tools/generate-coverage.mjs. That regeneratedcarrier-feature-data.mdx,shipping-lines.{json,csv,mdx}, and the agent section ofocean-carriers.mdx. Hand-edited:coverage/changelog.mdx(new 2026-10-14 entry, includes "enter the master BL without the SMLU prefix"), the Seaboard mention in the account-enabled paragraph ofcoverage/home.mdx(main's #426 already removed the hard-coded count from the ocean carrier card, so merging it left only that mention to change), and the public/account counts intools/generate-coverage.test.mjs(36 to 37, 2 to 1). No other SMLU features were changed: all other attributes stayunknown(no POD ETA or other attribute coverage is claimed).node tools/generate-coverage.mjs --checkand the coverage tests pass. After merging main (#426, #430) theverify-deployed-coveragetests show 5 failures that also occur on a cleanorigin/maincheckout in this sandbox, so they are not caused by this PR.Matthew Turner (engineering) confirmed in Slack on 2026-10-14 that the integration is live in production for all accounts and trackable by BL or container; this isn't verifiable from the repo (the staging migration registers
shipping_line.smlu.mobilewithdefault: false,weight: 0.0, so production config is database state).Not changed: the
carrierCoverageGeneratedOnexport date (2026-08-14) and the "36 ocean carriers, plus 2 more enabled on request, as of 14 August 2026" lines on thedocs/migrate/*.mdxpages, which are dated statements.🤖 Generated with Claude Code
https://claude.ai/code/session_01GvpwGFSoR7Ycun5PNufyGz
Generated by Claude Code
<source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg">'''https://backend.blacksmith.sh/track/enable-autofix?expires=1794537708&installation_model_id=18852&pr_number=429&ref=codesmith_pr_footer&repository=Terminal49%2FAPI&return_to=https%3A%2F%2Fgithub.com%2FTerminal49%2FAPI%2Fpull%2F429&signature=68bb17dd3ad1a154b36ce9ede6b78f738408fb884325e63ee30a57a80ad4395b"><picture><sourcemedia="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg">```Need help on this PR? Tag
@codesmith-botwith what you need.