Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An idle timeout and an absolute freshness deadline are different policies. PR #480 represented both with one last-touch timestamp, so continuously active fixed-timestamp input could remain open indefinitely.
Before this PR
A pane tracked only its latest wall-clock touch. The single
wall_clock_grace_period_mssetting implemented idle closure and could not bound the lifetime of an active pane.After this PR
wall_clock_idle_grace_period_ms; accept the old YAML name as a compatibility alias.wall_clock_max_open_grace_period_msabsolute deadline.For a one-second window with 5-second grace, idle closure fires six seconds after the latest touch, while the optional absolute deadline fires six seconds after the first touch even if the pane remains active.
Verification
cargo fmt -p data_plane -- --checkcargo test -p data_plane precompute_engine:: -- --nocapture(262 passed)Includes regression coverage for the absolute deadline and legacy configuration deserialization.
Stacked on #483; retarget to
mainafter #483 merges.