fix(precompute): preserve deadline corrections - #485
Merged
Merged
Conversation
zzylol
changed the base branch from
feat/precompute-window-close-policy
to
main
September 3, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
An absolute wall-clock deadline could close an active event-time pane while the default late-data policy still dropped later inputs. That bounded freshness by silently losing data. There was also no metric separating dropped late inputs from appended corrections.
After
ForwardToStoreguarantees mergeable correction output.ForwardToStorethe runtime/default policy and use a 5-second maximum-open grace.asap_precompute_late_inputs_total{action,input_kind}for drop/correction observability.Validation
cargo fmt -p data_plane -- --checkCARGO_TARGET_DIR=/mydata/ASAPQuery-backend/target cargo test -p data_plane precompute_engine::(265 passed)Drop.Stacked on #484; merge after #483 and #484.