fix(precompute): separate event and closure watermarks - #483
Merged
Merged
Conversation
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #480 prevented one short bulk-ingest failure by refreshing a pane idle timer, but periodic flushes still manufactured event time and unrelated groups could close each other.
allowed_lateness_msalso did not delay event-time closure.Before this PR
For a fixed timestamp, every timer flush advanced
previous_watermark_msby 1 ms. After enough flushes, valid input was classified as late. A newer group on the same worker could also force-close another group through max/min watermark propagation.After this PR
max_event_time - allowed_lateness.ForwardToStoreconsistently to raw samples rejected by either lateness or prior closure.Example: with a 10-second window and 5-second allowed lateness, observing event time 10s leaves
[0s, 10s)open; observing 15s closes it. Repeated timer flushes do not change that result.Verification
cargo fmt -p data_plane -- --checkcargo check -p data_plane --testscargo test -p data_plane precompute_engine:: -- --nocapture(260 passed)New regression coverage verifies repeated flushes, per-group isolation, allowed-lateness closure, and raw correction forwarding.