fix(precompute): keep active panes open - #480
Merged
Merged
Conversation
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The wall-clock fallback aged panes from their creation time. A long-running raw or sketch ingest with a fixed event timestamp could therefore force-close a pane while it was still receiving input; subsequent samples were treated as late and dropped. ASAPQuery fixed this in ProjectASAP/ASAPQuery#536, but the fix was missing after the backend split.
After
window_size + grace.active_panesandsketch_paneswith deterministic fake-clock regressions.Verification
cargo fmt -p data_plane -- --checkcargo test -p data_plane precompute_engine::worker::tests::wall_clock_fallback -- --nocapture(4 passed)cargo test -p data_plane precompute_engine::(259 passed)Upstream source: ProjectASAP/ASAPQuery@9a018cb (
fix(precompute): keep wall-clock fallback from force-closing panes still under active ingest).