Skip to content

PermissionController 2.0 - #28

Closed
rekmarks wants to merge 147 commits into
mainfrom
permissions-controller-v2
Closed

PermissionController 2.0#28
rekmarks wants to merge 147 commits into
mainfrom
permissions-controller-v2

Conversation

@rekmarks

@rekmarks rekmarks commented Jul 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

The permission system 2.0. See the README for details, and this PR on metamask-extension for what actually using it looks like.

Ref: MetaMask/rpc-cap#133

@rekmarks
rekmarks force-pushed the permissions-controller-v2 branch 3 times, most recently from 8454874 to 493742a Compare July 4, 2021 01:28
@rekmarks rekmarks mentioned this pull request Jul 15, 2021
Closed
11 tasks done
rekmarks
rekmarks commented Aug 7, 2021
View reviewed changes

@rekmarks rekmarks left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A.

shanejonas
shanejonas previously approved these changes Aug 7, 2021
View reviewed changes
@rekmarks
rekmarks marked this pull request as ready for review August 7, 2021 22:20
@rekmarks
rekmarks dismissed shanejonas’s stale review August 7, 2021 22:20

It was just for testing.

@rekmarks
rekmarks marked this pull request as draft August 7, 2021 22:21
@rekmarks
rekmarks force-pushed the permissions-controller-v2 branch 3 times, most recently from 15d36f3 to cb8033a Compare August 20, 2021 19:51
@rekmarks
rekmarks force-pushed the permissions-controller-v2 branch 5 times, most recently from 2339f04 to 1e22d47 Compare August 24, 2021 21:17
@rekmarks rekmarks mentioned this pull request Aug 31, 2021
Closed
@rekmarks
rekmarks force-pushed the permissions-controller-v2 branch 4 times, most recently from dac2e7b to 33ea7e2 Compare September 1, 2021 23:16
Gudahtt
Gudahtt reviewed Sep 7, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/PermissionController.test.ts Outdated
Gudahtt
Gudahtt reviewed Sep 7, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/rpc-methods/requestPermissions.ts
Gudahtt
Gudahtt reviewed Sep 8, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/PermissionController.ts
Gudahtt
Gudahtt reviewed Sep 8, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/PermissionController.ts Outdated
@rekmarks
rekmarks force-pushed the permissions-controller-v2 branch 3 times, most recently from 6321637 to 828cf30 Compare September 15, 2021 05:13
@rekmarks
rekmarks dismissed stale reviews from rkarendt via 91cf3df November 4, 2021 04:45
Gudahtt
Gudahtt reviewed Nov 5, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/permission-middleware.ts Outdated
Comment thread packages/controllers/src/permissions/rpc-methods/requestPermissions.ts
Comment thread packages/controllers/src/permissions/rpc-methods/requestPermissions.ts Outdated
Comment thread packages/controllers/src/permissions/rpc-methods/requestPermissions.ts Outdated
Comment thread packages/controllers/src/permissions/PermissionController.ts Outdated
Gudahtt
Gudahtt reviewed Nov 5, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/rpc-methods/getPermissions.ts Outdated
Comment thread packages/controllers/src/permissions/README.md
Comment thread packages/controllers/src/permissions/README.md Outdated
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts
Comment thread packages/controllers/src/permissions/Permission.ts
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Gudahtt
Gudahtt reviewed Nov 8, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts Outdated
Comment thread packages/controllers/src/permissions/Permission.ts
Gudahtt
Gudahtt reviewed Nov 9, 2021
View reviewed changes
Comment thread packages/controllers/src/permissions/Caveat.ts Outdated
Comment thread packages/controllers/src/permissions/Caveat.ts Outdated
Comment thread packages/controllers/src/permissions/Caveat.ts
Comment thread packages/controllers/src/permissions/Caveat.ts
Comment thread packages/controllers/src/permissions/Caveat.ts Outdated
rekmarks and others added 17 commits November 9, 2021 15:43
@rekmarks @Gudahtt
Apply suggestions from code review
0655728 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@rekmarks
fixup! Apply suggestions from code review
2bb2c55
@rekmarks
Remove constructCaveat
c2fd150
@rekmarks
Improve requested permission / caveat validation
36efcf7
@rekmarks
Make wallet_requestPermissions more readable
28a6365
@rekmarks
Improve variable name in wallet_getPermissions implementation
04bcbc4
@rekmarks
Improve KeyOfTargetName docstring
72524c3
@rekmarks
Simplify ExtractArrayMembers
ff0b6eb
@rekmarks
Make ExtractArrayMembers resolve to never for the empty tuple
bc7fdc3
@rekmarks
Simplify ExtractAllowedCaveatTypes
9299cae
@rekmarks
Remove unnecessary constructPermission cast
2f67293
@rekmarks
Rename GenericTargetName to TargetName
1ccbaf7
@rekmarks
Encapsulate ValidTargetName inside ExtractPermissionTargetNames
56ca078
@rekmarks
Simply CaveatSpecificationMap type
14ec184
@rekmarks
Add a TODO comment
3014a63
@rekmarks
Remove unused default branches
118bbc9
@rekmarks
Change requestPermission origin parameter to subject metadata
b4fae68
@rekmarks rekmarks mentioned this pull request Nov 11, 2021
Merged
@rekmarks

rekmarks commented Nov 11, 2021

Copy link
Copy Markdown
Contributor Author

Superseded by #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt left review comments
@shanejonas shanejonas Awaiting requested review from shanejonas
+1 more reviewer
@rkarendt rkarendt rkarendt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rekmarks @shanejonas @Gudahtt @rkarendt