Repository navigation
PermissionController 2.0 - #132
Merged
Merged
Conversation
Closed
rekmarks
commented
Nov 12, 2021
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
rekmarks
force-pushed
the
permissions-controller-v2-PR2
branch
from
November 17, 2021 03:50
814429d to
cd37424
Compare
Gudahtt
reviewed
Nov 17, 2021
Gudahtt
reviewed
Nov 17, 2021
Gudahtt
reviewed
Nov 22, 2021
Gudahtt
reviewed
Nov 23, 2021
Gudahtt
reviewed
Nov 23, 2021
Gudahtt
reviewed
Nov 23, 2021
Gudahtt
left a comment
Gudahtt
left a comment
Member
There was a problem hiding this comment.
These tests are fantastic! I've just finished reviewing everything. Ready to approve when all outstanding comments have been addressed.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Nov 23, 2021
This was referenced Nov 23, 2021
rekmarks
added a commit
that referenced
this pull request
Dec 8, 2021
Following #132, restricted methods can no longer be bound to the requesting origin. Instead, they receive a single object parameter with an object property `context`, which in turn has a string property `origin` that identifies the the subject that made the request. This PR ensures that all restricted method hooks use `context.origin` where necessary instead of assuming that they are bound to the requesting origin.
rekmarks
added a commit
that referenced
this pull request
Dec 10, 2021
Following #132, restricted methods can no longer be bound to the requesting origin. Instead, they receive a single object parameter with an object property `context`, which in turn has a string property `origin` that identifies the the subject that made the request. This PR ensures that all restricted method hooks use `context.origin` where necessary instead of assuming that they are bound to the requesting origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The permission system 2.0. See the README for details, and this PR on
metamask-extensionfor what actually using it looks like.Ref: MetaMask/rpc-cap#133
Supersedes #28