Repository navigation

PermissionController 2.0 - #28

Closed

rekmarks wants to merge 147 commits into

mainfrom

permissions-controller-v2

Commits on Oct 1, 2021
- Begin work on PermissionsController refactor
  rekmarks
  committed
  bc86edc
- Update function generators, add caveat types test
  rekmarks
  committed
  848f4c5
- Fixup caveat function gen. types and errors
  rekmarks
  committed
  6ed5d49
- Use modifed ZCAP-LD interfaces for caveats and permissions
  rekmarks
  committed
  746f1bf
- Add errors, some basic functions
  rekmarks
  committed
  d678853
- Refactor caveats as middleware functions
  rekmarks
  committed
  ff38cce
- Implement state management primitives
  rekmarks
  committed
  87d3a04
- chore: lint, post-rebase fixup
  rekmarks
  committed
  cb86f11
- domain -> actor, update actions/events, register action handlers
  rekmarks
  committed
  fa793c3
- Add getCaveatValue static method
  rekmarks
  committed
  8a2f313
- Fixups: return types, comments, code clarity, etc.
  rekmarks
  committed
  724f8e1
- Clean up events and actions
  rekmarks
  committed
  bd46ea5
- actors -> subjects
  rekmarks
  committed
  dc19143
- Clean up caveat processing
  rekmarks
  committed
  718e8b7
- Add PermissionEnforcer
  rekmarks
  committed
  fc544c5
- Add consumer-specified caveat value validation
  rekmarks
  committed
  3f7532a
- Add revokePermissionForAllSubjects
  rekmarks
  committed
  741cb76
- Rename some stuff in the PermissionEnforcer
  rekmarks
  committed
  8ea589f
- Post-rebase fixup
  rekmarks
  committed
  e59568d
- DRY up some restricted method validation
  rekmarks
  committed
  7e1ea6d
- Remove safelyExecuteRestrictedMethod
  rekmarks
  committed
  360fc34
- Re-implement caveat decoration per suggestion by @Gudahtt
  rekmarks
  committed
  f1b65bb
- Require that caveat functions are async
  rekmarks
  committed
  6c66ab6
- Update caveat state management
  rekmarks
  committed
  4088421
- Fixup / tweak
  rekmarks
  committed
  2024b51
- Implement RPC methods, use types over interfaces
  rekmarks
  committed
  747f120
- Fix requestPermissions return value
  rekmarks
  committed
  3849fc1
- Add permission specifications and accept/reject hooks
  rekmarks
  committed
  7e00e61
- Remove some cruft
  rekmarks
  committed
  48289f7
- Add enums, export controller, refactor internal exports
  rekmarks
  committed
  b517440
- Rename SubjectMetadata to PermissionsSubjectMetadata
  rekmarks
  committed
  5fef679
- fixup! Rename SubjectMetadata to PermissionsSubjectMetadata
  rekmarks
  committed
  44ef0b6
- Assume that permission factories produce valid outputs
  rekmarks
  committed
  047e787
- Various tweaks and fixups
  rekmarks
  committed
  2214b7c
- @metamask/controllers@15.0.0
  rekmarks
  committed
  19219b3
- Make PermissionEnforcer a PermissionController property
  rekmarks
  committed
  b262c88
- WIP: Tests
  rekmarks
  committed
  14474a8
- Remove temporary type declaration files
  rekmarks
  committed
  4b4efbe
- Add permission system readme, rename some things
  rekmarks
  committed
  a761273
- Post-rebase fixup
  rekmarks
  committed
  db1fd30
- Stop using 'in' operator
  rekmarks
  committed
  fc99e7d
- WIP: Improved type safety 1 (unstable)
  rekmarks
  committed
  8a07f64
- WIP: Improved type safety 2 (builds)
  rekmarks
  committed
  fd98a4a
- WIP: Improved type safety 3 (mostly cleanup left)
  rekmarks
  committed
  d8cbb09
- Post-rebase fixup
  rekmarks
  committed
  27a7a36
- WIP: Improved type safety 4 (fix permission specifications)
  rekmarks
  committed
  95e4580
- Complete: Improved type safety
  rekmarks
  committed
  5ab713f
- Unit tests: PermissionController.grantPermissions
  rekmarks
  committed
  4c15b7a
- Fix caveat function type safety for namespaced permissions
  rekmarks
  committed
  c912a4a
- Some type fixup
  rekmarks
  committed
  7cfd26b
- Add HasPermissions action
  rekmarks
  committed
  c51f6d9
- Fix some parameters, rename an export
  rekmarks
  committed
  d3b1984
- Add back getCaveat, refactor permission revocation
  rekmarks
  committed
  e1a6242
- Unit tests: PermissionController, continued
  rekmarks
  committed
  2deff4f
- Update permission requestData handling
  rekmarks
  committed
  6d2e92b
- Unit tests: PermissionController, revocation complete
  rekmarks
  committed
  8860625
- Unit tests: PermissionController, caveats complete
  rekmarks
  committed
  0d4f5b4
- Unit tests: PermissionController, caveats complete
  rekmarks
  committed
  9fd6d67
- Unit tests: PermissionController, caveat errors
  rekmarks
  committed
  f7b2798
- Fix target key validation
  rekmarks
  committed
  ad34223
- Unit tests: PermissionController, actions
  rekmarks
  committed
  9aeb9f2
- Remove some unused errors
  rekmarks
  committed
  fdda927
- fixup! Remove some unused errors
  rekmarks
  committed
  a22697e
Commits on Oct 2, 2021
- Add test helper docstrings, more test cases
  rekmarks
  committed
  a4fa33d
Commits on Oct 4, 2021
- Add additional runtime validation to grantPermissions
  rekmarks
  committed
  8326953
Commits on Oct 5, 2021
- Consolidate enforcement in PermissionController
  rekmarks
  committed
  74e2fb7
- Fix restricted method params type
  rekmarks
  committed
  a8acab4
- Unit tests: PermissionController.requestPermissions
  rekmarks
  committed
  0e216de
- Document requestPermissions and related methods
  rekmarks
  committed
  4a7f73f
Commits on Oct 6, 2021
- Unit tests: accept and rejectPermissionsRequest
  rekmarks
  committed
  04a8352
Commits on Oct 7, 2021
- Unit tests: begin executeRestrictedMethod
  rekmarks
  committed
  b9fbe47
- WIP: Restricted method types
  rekmarks
  committed
  4b74e21
- WIP: Restricted method types II
  rekmarks
  committed
  3acb6f3
- WIP: Messy
  rekmarks
  committed
  531d5ad
Commits on Oct 8, 2021
- WIP: Refactor controller types (Builds)
  rekmarks
  committed
  6e151ae
Commits on Oct 9, 2021
- WIP: Refactor controller types II (Builds)
  rekmarks
  committed
  f5cd9d0
- WIP: Refactor controller types III (caveat specifications generic)
  rekmarks
  committed
  eeb6812
- WIP: Refactor controller types IV (cleanup)
  rekmarks
  committed
  fa61f4f
- WIP: Refactor controller types V (more cleanup)
  rekmarks
  committed
  cf0f547
- Refactor controller types 😭🙏
  rekmarks
  committed
  8383525
- Restore caveat method type safety
  rekmarks
  committed
  d27dcee
- fixup! Restore caveat method type safety
  rekmarks
  committed
  b56b354
Commits on Oct 10, 2021
- Status quo ante type refactor
  rekmarks
  committed
  4078aee
- Unit tests: PermissionController, complete
  rekmarks
  committed
  99c8454
- Unit tests: Complete Caveat, Permission, and errors files
  rekmarks
  committed
  4df1d36
- Some comment / type fixup
  rekmarks
  committed
  8977b19
- Add PermissionController.updateAllCaveatsOfType
  rekmarks
  committed
  9b15377
- Fix permission specification getting
  rekmarks
  committed
  8ef3113
- Unit tests: permission middleware
  rekmarks
  committed
  4c410be
Commits on Oct 11, 2021
- Unit tests: fin.
  rekmarks
  committed
  d80c31c
- Update README
  rekmarks
  committed
  f171a35
Commits on Oct 13, 2021
- Minor test wording fixup
  rekmarks
  committed
  0fed096
- Update packages/controllers/src/permissions/README.md
  rekmarks
  authored
  c492759
- Update packages/controllers/src/permissions/README.md
  
  rekmarks
  and
  Gudahtt
  authored
  33105e1
- Update packages/controllers/src/permissions/README.md
  
  rekmarks
  and
  Gudahtt
  authored
  d724b56
Commits on Oct 18, 2021
- Simplify types
  rekmarks
  committed
  0556f82
- fixup! Simplify types
  rekmarks
  committed
  6fed1c8
- More documentation and type fixup
  rekmarks
  committed
  ea899da
- Fix parameter names of ExtractArrayMembers
  rekmarks
  committed
  4a1dd83
- Fix the ExtractPermission docstring, take II
  rekmarks
  committed
  1d90813
- Fix readme
  rekmarks
  committed
  8fa50a5
Commits on Oct 26, 2021
- Replace GenericFunction with something more specific
  rekmarks
  committed
  b1105f9
- Remove GenericPermission, use PermissionConstraint
  rekmarks
  committed
  c3cbe8d
- Fixup
  rekmarks
  committed
  fa86d30
- More type fixup
  rekmarks
  committed
  b14367f
- Rename more types from Validate* to Valid*
  rekmarks
  committed
  8603b41
- Get rid of PermissionValidator generic
  rekmarks
  committed
  9204cfc
- Improve caveat specification type safety
  rekmarks
  committed
  3d3cdf2
- Remove leftover comment
  rekmarks
  committed
  20298a6
- Replace state metadata and default state consts with getters
  rekmarks
  committed
  3629734
- Simplify PermissionControllerOptions
  rekmarks
  committed
  fca8ab5
- Improve PermissionControllerSubjects
  rekmarks
  committed
  a06545e
Commits on Oct 28, 2021
- Update packages/controllers/src/permissions/PermissionController.ts
  
  rekmarks
  and
  Gudahtt
  authored
  d42c119
- Address review feedback
  rekmarks
  committed
  b0b7997
Commits on Oct 29, 2021
- Simplify permission-middleware types, add docs
  rekmarks
  committed
  f2c8e49
- Verify that caveat values are JSON-compatible
  rekmarks
  committed
  799f9fa
Commits on Oct 31, 2021
- Apply suggestions from code review
  
  rekmarks
  and
  Gudahtt
  authored
  226ecaa
- fixup! Apply suggestions from code review
  rekmarks
  committed
  2aed963
- Remove leftover typecast comments
  rekmarks
  committed
  37b75f9
- Rename Permission generic type to ValidPermission
  rekmarks
  committed
  4d24c94
Commits on Nov 2, 2021
- Add NonEmptyArray type guard
  rekmarks
  committed
  5ce5f80
- Apply suggestions from code review
  
  rekmarks
  and
  Gudahtt
  authored
  9307b5a
- fixup! Apply suggestions from code review
  rekmarks
  committed
  b8fbba7
Commits on Nov 3, 2021
- Improve some validation, address review feedback
  rekmarks
  committed
  11e318e
Commits on Nov 4, 2021
- Apply suggestions from code review
  
  rekmarks
  and
  Gudahtt
  authored
  606ed4f
- Clean up some target name and key parameter types
  rekmarks
  committed
  e1e50dd
- Rationalize getRestrictedMethod implementations
  rekmarks
  committed
  fb667ff
- Fix a comment
  rekmarks
  committed
  47ff014
- fixup! Fix a comment
  rekmarks
  committed
  de43571
- Address review feedback
  rekmarks
  committed
  91cf3df
Commits on Nov 9, 2021
- Apply suggestions from code review
  
  rekmarks
  and
  Gudahtt
  authored
  0655728
Commits on Nov 10, 2021
- fixup! Apply suggestions from code review
  rekmarks
  committed
  2bb2c55
- Remove constructCaveat
  rekmarks
  committed
  c2fd150
- Improve requested permission / caveat validation
  rekmarks
  committed
  36efcf7
- Make wallet_requestPermissions more readable
  rekmarks
  committed
  28a6365
- Improve variable name in wallet_getPermissions implementation
  rekmarks
  committed
  04bcbc4
- Improve KeyOfTargetName docstring
  rekmarks
  committed
  72524c3
- Simplify ExtractArrayMembers
  rekmarks
  committed
  ff0b6eb
- Make ExtractArrayMembers resolve to never for the empty tuple
  rekmarks
  committed
  bc7fdc3
- Simplify ExtractAllowedCaveatTypes
  rekmarks
  committed
  9299cae
- Remove unnecessary constructPermission cast
  rekmarks
  committed
  2f67293
- Rename GenericTargetName to TargetName
  rekmarks
  committed
  1ccbaf7
- Encapsulate ValidTargetName inside ExtractPermissionTargetNames
  rekmarks
  committed
  56ca078
- Simply CaveatSpecificationMap type
  rekmarks
  committed
  14ec184
- Add a TODO comment
  rekmarks
  committed
  3014a63
- Remove unused default branches
  rekmarks
  committed
  118bbc9
Commits on Nov 11, 2021
- Change requestPermission origin parameter to subject metadata
  rekmarks
  committed
  b4fae68

Commits

Commits on Oct 1, 2021

Commits on Oct 2, 2021

Commits on Oct 4, 2021

Commits on Oct 5, 2021

Commits on Oct 6, 2021

Commits on Oct 7, 2021

Commits on Oct 8, 2021

Commits on Oct 9, 2021

Commits on Oct 10, 2021

Commits on Oct 11, 2021

Commits on Oct 13, 2021

Commits on Oct 18, 2021

Commits on Oct 26, 2021

Commits on Oct 28, 2021

Commits on Oct 29, 2021

Commits on Oct 31, 2021

Commits on Nov 2, 2021

Commits on Nov 3, 2021

Commits on Nov 4, 2021