Skip to content

Add ControllerMessenger events and actions to SnapController #65

Closed
Closed
Add ControllerMessenger events and actions to SnapController#65

Description

@rekmarks
rekmarks
opened on Aug 31, 2021

The SnapController should use ControllerMessenger events and actions to their full effect. Currently, it doesn't define any actions or events in addition to stateChange.

This is a refactoring ticket that we should undertake after the permissions controller changes are landed.

Activity

  1. rekmarks commented on Aug 31, 2021

    @rekmarks
    rekmarks
    on Aug 31, 2021
    ContributorAuthor

    Blocked by #28.

  2. rekmarks
    added this to the milestone on Aug 31, 2021
  3. rekmarks
    changed the title [-]Add proper ControllerMessenger events and actions to PluginController[/-] [+]Add ControllerMessenger events and actions to PluginController[/+] on Aug 31, 2021
  4. rekmarks
    added a commit that references this issue on Sep 7, 2021

    Add comment strip option (#65)

    14e1bcb
  5. rekmarks
    removed this from the milestone on Nov 4, 2021

  6. rekmarks commented on Nov 4, 2021

    @rekmarks
    rekmarks
    on Nov 4, 2021
    ContributorAuthor

    Hey team! Please add your planning poker estimate with ZenHub @Gudahtt @jknoll @shanejonas

  7. rekmarks
    changed the title [-]Add ControllerMessenger events and actions to PluginController[/-] [+]Add ControllerMessenger events and actions to SnapController[/+] on Nov 18, 2021

  8. rekmarks commented on Nov 19, 2021

    @rekmarks
    rekmarks
    on Nov 19, 2021
    ContributorAuthor

    Note: This is blocked by the new permissions system.

  9. ritave commented on Jan 10, 2022

    @ritave
    ritave
    on Jan 10, 2022
    Contributor

    Events were added here #162

  10. ritave
    closed this as completedon Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions