Repository navigation
Add Snap installation events - #162
Merged
Merged
Conversation
rekmarks
force-pushed
the
snap-installation-events
branch
from
December 15, 2021 08:46
771c0ff to
1bc4dcf
Compare
ritave
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds installation-related
ControllerMessengerevents to theSnapController, fixes a bug ininstallSnaps, makes some methods private, and deletesrunExistingSnaps.The following events are added:
snapAdded, emitted when a Snap has been added to state and its status isinstallingsnapInstalled, emitted when a Snap has been fully installedsnapRemoved, emitted when a Snap is removedA bug was introduced in #140, where a successfully installed Snap would be overwritten with an unrelated error in the
installSnapsresult object. This PR prevents this overwrite from happening.The
authorizeandprocessRequestedSnapmethods are made private, since they should never be called by third parties. In truth,addshould also be private, but we currently rely on it for the majority of our tests, and will attend to it later.Finally, the
runExistingSnapsmethod is removed because it's a hangover from the old Snaps lifecycle.