Dev by Av3boy · Pull Request #120 · Av3boy/SharpEngine

Av3boy · 2025-12-13T13:38:16Z

<Issue number> <Change title>

Checklist

I have merged the latest changes from main to my branch.
I have tested my changes and any affected components.
I have added the proper documentation about my changes
I have made sure there is no overlapping work.
I have discussed any / all issues brought up from code review.

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>

* Fix commit history (#113) * Temp * Fix * Fix UI element rendering * Use safe code * One more unsafe fix * Added error logging * Basic OpenAL implementation * #16 Remove unnecessary tester project * #26 Editor enhancements * #26 Context menu size fix and documentation * #26 Editor improvements * Method for opening multiple windows * Small refactoring * Opening SharpEngine windows works * UI improvements (WIP) A lot of stuff is unfinished. Context menu locations, launcher styling, xml documentation missing etc. Functionality should be working tho * Launcher UI improvements * Cleanup * Cleanup UIElement mesh data * Cleanup * Texturing improvements * Add basic layout placeholders * UI shader testing (WIP) * UI rendering works * Actual fix * Generalize functions * Fiddle with Transforms and types (WIP) * Midway solution (Not finished) * Getting there * Transform abstraction * UI element ortographic projection * Translating somewhat works * UI transform behaving correctly? * Add documentation / general enhancements * #2 Framing and rendering changes * Pop stash * #26 Fix build * #26 Fix flags * #26 Use width and height * #2 Temp * #2 loop working * #2 Refactoring Introduced obj loader, abstracted some functionality into separate projects, added placeholders for test projects * #2 Cleanup * #2 Separated Shader data container and extension methods * #2 Use correct ui shaders * #2 Fix absolute path bug * #2 Fix build (WIP) * #2 Cleanup * #2 Remove redundant interfaces * #2 More redundant interfaces * #2 More redundancies * #2 simplify data store * #2 Fixing readme details * #2 Simplify call * #2 Quality of life improvements * #2 Use mesh in obj loader * #2 Try map to old format * #2 Use Silk.NET example for debugging purposes * #2 Consolidate new changes * #67 Partial class definition * #2 Use Core Shader in tutorial * #2 Remove redundancies and plan merging * #2 Texture partial class * #2 Improve texture class * #2 Cleanup * #2 More cleanup * #2 Get rid of duplicates * #2 Reorganize content * #2 Using Core data types (Silk example no longer works) * #2 Intermediate state Both test projects work but the Model_Old is still required. * #73 Document issues * #73 Add missing issue links * #2 Use obsolete loader Let's use Model_Old for now to resolve the meshes. Later on once we are implementing the fbx stuff we can try to figure out again how to make the loader properly work. * #2 Using custom meshes in engine works * #2 A very bandaid solution for the obj renderer The implementation works but it's very hacky. This needs to fixed * #2 Cherrypick * #2 Tiny cleanup * #2 Shader issue? * #2 A very slow though "working" solution Textures still missing and the framerate is very bad * #2 Progress! * #2 Pop stash * #2 pop stash * #2 Cleanup IDisposables * #2 Cleanup * #2 Cleanup * #2 Pop stash * #2 A few warnings cleanup * #2 Try clean reliability ratings * #2 Light cleaning up * #2 Cleanup * #2 Fix * #52 gamification (#112) * #52 Modify folder structure * #52 Initial backend project * #52 Initial databases * #52 Temp arch in place --------- Co-authored-by: Antti Veikkolainen <anttiv@recastsoftware.com> --------- Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com> Co-authored-by: Antti Veikkolainen <anttiv@recastsoftware.com> * #52 Fix files (#114) Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com> * #52 Add marketing and asset store sites (WIP) * #52 Initial UI for websites * Small frontend additions * Fix README.md links * ci: add Azure Static Web Apps workflow file on-behalf-of: @Azure opensource@microsoft.com * #52 Package lock * #52 Hook yml to feature branch * #52 Test run pipeline * #52 Remove space from path * #52 Remove step backs * #52 Try ignore warnings * #52 Try fix output * #52 output test * #52 Placeholder pipelines --------- Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com> Co-authored-by: Antti Veikkolainen <anttiv@recastsoftware.com>

+    runs-on: ubuntu-latest
+    steps:
+      - name: Echo message
+        run: echo "Hello from the test branch 👋"


To fix the problem, an explicit permissions block should be added to the workflow, limiting the permissions of the automatically provided GITHUB_TOKEN. The most restrictive option—unless a specific permission is required—is permissions: {} at the workflow root or at the relevant job level (here, the entire workflow only echoes a message and does not require any permissions). Place the new permissions block at the root, just after the namekey and before theon` key, to apply to all jobs by default. No additional imports, methods, or code are required beyond the insertion of this YAML block.

+    runs-on: ubuntu-latest
+    steps:
+      - name: Echo message
+        run: echo "Hello from the test branch 👋"


To fix the problem, add an explicit permissions block to the workflow, restricting the GitHub token to the minimal permission required. In this specific workflow, the only job (echo) just runs a shell command to print a message and does not require any permissions to access repository contents or perform actions with the GitHub token.

The best-practice fix is to set permissions: {} (which is equivalent to disabling all permissions) at the workflow/root level, immediately after the name: declaration and before the on: trigger. This ensures that all jobs in the workflow get no token permissions by default. No code or functionality will be changed by this update, and no additional imports, packages, or code changes are necessary.

Edit .github/workflows/publish-docs.yml:

Insert a permissions: {} block after the workflow name at line 2.

+    runs-on: ubuntu-latest
+    steps:
+      - name: Echo message
+        run: echo "Hello from the test branch 👋"


To fix this problem, explicitly declare a permissions block in your workflow YAML. Since the shown publish-launcher.yml workflow simply runs an echo command and does not appear to need any repository access, the most restrictive permissions, i.e., permissions: {} (no permissions), can be safely used. You can add this at the root of the workflow to apply to all jobs, or specifically within the echo job if desired. The most standard approach is to place it at the workflow root, immediately after the name key.

This involves editing .github/workflows/publish-launcher.yml by adding the following lines after the name property:

permissions: {}

No dependencies, imports, or further code changes are required.

sonarqubecloud · 2025-12-13T13:40:05Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Copilot reviewed 113 out of 163 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T13:42:55Z

+  return await apiRequest<Asset[]>(`${Routes.ClientBase}/api/decks`, {
+    method: "GET",
+    headers: {
+      Authorization: `Bearer ${token}`,
+    },
+  });


The referenced property 'Routes.ClientBase' does not exist. Based on the Routes object definition (lines 2-6), only 'AssetStore' and 'Portal' are available. This will cause a runtime error.

Copilot · 2025-12-13T13:42:55Z

+    /// <summary>
+    ///     Initializes the ga
+    /// </summary>


The comment describes this function as "Initializes the ga" but appears to be cut off. Complete the documentation to explain what this method initializes (likely "game window").

Copilot · 2025-12-13T13:42:55Z

+    public async Task Login()
+    {
+        // TODO: Create user (if not exists) when auth0 login done
+        // We need a copy of the user to link achievements
+    }


The Login method is defined with a TODO comment but has no implementation. Either implement the method or remove it if it's not ready for inclusion in this PR.

Copilot · 2025-12-13T13:42:55Z

+export type AssetComment = {
+}


The AssetComment type is defined but empty. This incomplete type definition should either have properties added or be removed if not yet needed.

Copilot · 2025-12-13T13:42:56Z

+export default function Test() {
+
+}


The Test component is defined but has no implementation. Either add the component logic or remove this file if it's not needed.

Copilot · 2025-12-13T13:42:57Z

+  const [showDropdown, setShowDropdown] = useState(false);
+  const searchRef = useRef<HTMLDivElement>(null);
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable isAuthenticated.

Copilot · 2025-12-13T13:42:57Z

+  const [showDropdown, setShowDropdown] = useState(false);
+  const searchRef = useRef<HTMLDivElement>(null);
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable user.

Copilot · 2025-12-13T13:42:57Z

@@ -0,0 +1,70 @@
+import { useState } from 'react';
+import { useNavigate } from 'react-router-dom';
+import { ChevronDown, User } from 'lucide-react';


Unused import User.

Copilot · 2025-12-13T13:42:57Z

+export function Header() {
+  const navigate = useNavigate();
+  const [isDropdownOpen, setIsDropdownOpen] = useState(false);
+  const [isLoggedIn] = useState(false); // Change this to true to simulate logged in state


Unused variable isLoggedIn.

Copilot · 2025-12-13T13:42:58Z

+
+export function HeaderLogin({ onProfileClicked }: { onProfileClicked: () => void }) {
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable user.

Av3boy and others added 4 commits December 6, 2025 17:33

#52 Remove redundant sln file (#116)

79d4471

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>

#52 Fix files (#117)

98bb01a

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>

Merge remote-tracking branch 'origin/main' into dev

5fe20b8

Copilot AI review requested due to automatic review settings December 13, 2025 13:38

Av3boy self-assigned this Dec 13, 2025

Copilot started reviewing on behalf of Av3boy December 13, 2025 13:38 View session

github-advanced-security AI found potential problems Dec 13, 2025

View reviewed changes

Av3boy merged commit d24797a into main Dec 13, 2025
8 checks passed

Copilot AI reviewed Dec 13, 2025

View reviewed changes

@@ -1,4 +1,5 @@
             name: Publish Asset Store _ Temp
+            permissions: {}
             on:
               push:

@@ -1,4 +1,5 @@
             name: Publish Docs
+            permissions: {}
             on:
               push:

@@ -1,4 +1,5 @@
             name: Publish Launcher
+            permissions: {}
             on:
               push:


		export function HeaderLogin({ onProfileClicked }: { onProfileClicked: () => void }) {

		const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();

Conversation

Av3boy commented Dec 13, 2025

<Issue number> <Change title>

Contents

Checklist

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Uh oh!

Uh oh!

sonarqubecloud Bot commented Dec 13, 2025

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants