Add refcounting semantics to VideoFrame - #167
Merged
Merged
Conversation
…decs into videoframe_clone_close
aboba
approved these changes
Apr 6, 2021
padenot
requested changes
Apr 7, 2021
padenot
left a comment
padenot
left a comment
Collaborator
There was a problem hiding this comment.
This needs clarification about ownership, and other fixes, but in general is what we need.
chcunningham
commented
Apr 9, 2021
Collaborator
Author
|
@padenot , similar to the audio issue, I think we at least have agreement on the API shape and its intended meaning. Would you mind approving the merge here and doing follow up issues for any lingering wording/style concern? |
Collaborator
Author
Replaces the ImageBitmap constructor with more generic constructor for CanvasImageSource. VideoFrame is itself a CanvasImageSource. Fixes #158
This was referenced Apr 22, 2021
padenot
requested changes
Apr 28, 2021
chcunningham
commented
Apr 28, 2021
chcunningham
left a comment
chcunningham
left a comment
Collaborator
Author
There was a problem hiding this comment.
Thanks @padenot - I'll send a fix for the nit. Otherwise, we've agreed to merge and handle remainder in follow ups.
chcunningham
commented
Apr 30, 2021
chcunningham
left a comment
chcunningham
left a comment
Collaborator
Author
There was a problem hiding this comment.
Thanks, all comments addressed
…decs into videoframe_clone_close
padenot
approved these changes
Apr 30, 2021
padenot
left a comment
padenot
left a comment
Collaborator
There was a problem hiding this comment.
Good for merging now, thanks!
Collaborator
Author
|
This one depends on #162, so I'll merge it as soon as that one goes in. |
…eoframe_from_canvasimagesource
Construct VideoFrame from CanvasImageSource (including VideoFrame)
Collaborator
Author
|
I'll merge back to main manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it symmetric w/ AudioFrame (PR #162)
Adds clone/close
Adds [[resource reference]]
Updates constructors accordingly (and fix cruft/obsolete steps).
Removes destroy (replaced by close).
Fixes #129
Notes issues #165 and #166 for follow up.
Preview | Diff