Skip to content

Define internal slots as backing for VideoFrame attributes - #190

Merged
chcunningham merged 2 commits into
mainfrom
videoframe_slots
Apr 23, 2021
Merged

chcunningham merged 2 commits into
mainfrom
videoframe_slots

Conversation

@chcunningham

@chcunningham chcunningham commented Apr 23, 2021

Copy link
Copy Markdown
Collaborator

Adds slots for all VideoFrame attributes and updates all references to attributes to instead reference the slots. This is an increment step toward resolving #184.


Preview | Diff

Purely mechanical change (behavior and interface unchanged). This is an
increment step toward resolving #184.
@chcunningham

Copy link
Copy Markdown
Collaborator Author

@padenot @aboba - This is a purely mechanical change (behavior and interface unchanged) to add slots for attributes, so I'll go ahead and merge.

Note that I updated the VideoFrame constructor steps to correctly initialize the slots, but most of these steps are actually re-written by PR #167.

@chcunningham
chcunningham merged commit a4ef61b into main Apr 23, 2021
@chcunningham
chcunningham deleted the videoframe_slots branch June 2, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant