Construct VideoFrame from CanvasImageSource (including VideoFrame) - #185
Merged
chcunningham merged 3 commits intoMay 5, 2021
Merged
Conversation
Replaces the ImageBitmap constructor with more generic constructor for CanvasImageSource. VideoFrame is itself a CanvasImageSource. Fixes #158
dalecurtis
reviewed
Apr 19, 2021
dalecurtis
reviewed
Apr 19, 2021
padenot
reviewed
Apr 28, 2021
chrisn
reviewed
Apr 28, 2021
chcunningham
commented
Apr 28, 2021
chcunningham
left a comment
chcunningham
left a comment
Collaborator
Author
There was a problem hiding this comment.
Editors call: looks good with minor comments addressed
Collaborator
Author
|
Editors call: consider approved % addressing minor comments |
…eoframe_from_canvasimagesource
chcunningham
commented
May 4, 2021
chcunningham
left a comment
chcunningham
left a comment
Collaborator
Author
There was a problem hiding this comment.
Thanks for reviewing.
Collaborator
Author
|
I'll merge this back to main manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the ImageBitmap constructor with more generic constructor for
CanvasImageSource. VideoFrame is itself a CanvasImageSource.
frame.createImageBitmap() is removed, as we can now instead call createImageBitmap(frame).
Fixes #145. Also, see #158.
Preview | Diff