Repository navigation
Ignore the two urllib3 CVEs until the lock next moves - #741
Merged
Merged
Conversation
urllib3 2.7.0 -> 2.8.0 changes uv.lock, which sends every desktop install to a full download instead of the one-click update, two days after 0.19.0 already did. StemDeck's own requests use the standard library's urllib; urllib3 only serves model and data downloads from fixed hosts through requests. The entry says when to drop it.
Merged
thcp
added a commit
that referenced
this pull request
Oct 2, 2026
Release 0.19.1: everything on `next-release` since v0.19.0. - #727: slowed playback without stutter, doubled kicks or echo (Signalsmith Stretch as the tempo stage). - #737: the bugs reported against 0.19.0 (CUDA setup, torch that cannot load, favourites in a narrow window, minor keys, the key label). - #740: the remaining open issues (top bar and Extract stems, the card at every width, favourites on the phone, the lyrics lookup on the server, an adjustable slow speed, Rust advisories). - #741: trivy ignores the two urllib3 CVEs until the lock next moves. - #743: a 0.5x button beside the slow speed. Verified on local Windows NVIDIA builds: 0.19.1.dev0 passed 12 of 12 (#727, #737), and 0.19.1.dev1 passed 18 of 18 automated checks including #740, in an isolated profile. `uv.lock` is unchanged since v0.19.0, so the in-app update works. Closes #722 Closes #728 Closes #729 Closes #723 Closes #724 Closes #726 Closes #730 Closes #731 Closes #732 Closes #733 Closes #736 Closes #701 Closes #738 Closes #725 Closes #735 Closes #734 Closes #719 Closes #742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivy fails on CVE-2026-97687 and CVE-2026-97689 in urllib3 2.7.0 (fixed in 2.8.0). Bumping it changes
uv.lock, which sends every Windows and Linux desktop install to a full download instead of the one-click update, two days after 0.19.0 already did.StemDeck's own requests use the standard library's
urllib. urllib3 comes in only throughrequests, for model and data downloads from fixed hosts (audio-separator, librosa's pooch, Whisper's tiktoken). The first CVE needs an HTTPS proxy configured, the second a hostile server on one of those downloads..trivyignorerecords why, and says to take the bump the next time the lock moves for another reason, the same way CVE-2026-63374 is handled.