fix(web): size the Android fold model from the inner display

[juliusmarminge]

Follow-up to #13534. The Android fold model used one fixed near-square body. That matches the Pixel 9/10 Pro Fold (2076×2152 inner display), but a natively landscape inner panel such as the first-generation Pixel Fold (2208×1840) was stretched onto it.

The fold scene now takes the inner display's aspect and builds the body, bezels, hinge and cover around it. The viewer reads that aspect from the unfolded raw frame. It keeps the last unfolded shape while the cover frame streams, and rebuilds the body at the visible hinge angle when a different inner shape arrives. UVs and touch mapping stay in raw-frame space, so no rotation is added.

Verification

• Pixel 10 Pro Fold emulator in the web Device panel: unfolded 3D view matches the flat view, with round icons and no stretch.
• New tests: the inner screen matches portrait (2076×2152) and landscape (2208×1840) frames, and the viewer widens the body for a landscape frame and keeps it through the cover frame. The viewer test fails without the change.
• packages/client-runtime/src/device tests: 125 passed. Targeted lint and client-runtime TypeScript checks passed.

No landscape-panel emulator was available, so the 2208×1840 case is covered by tests only.

Visual evidence

Pixel 10 Pro Fold, unfolded (unchanged shape, no stretch)

UI-visible behavior only changes for landscape inner panels; the Pixel 10 Pro Fold renders as before.

Model: Claude Opus 5.5. Harness: Claude Code.

🤖 Generated with Claude Code

---

Summary by CodeRabbit

• New Features
  • Android foldable phone displays now adapt to the aspect ratio of the source image, including wider landscape displays.
  • Fold display dimensions update when the source image changes, while preserving the current hinge angle and keeping the device model consistent during cover-frame updates.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+41 B (+0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	−2 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+43 B (+0.7%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.2 KiB	56.3 KiB	+44 B (+0.1%)	66.4 KiB	✅
Codex	Live turn messages	9	10	+1 (+11.1%)	21	✅
Claude	Total thread wire	13.6 KiB	13.5 KiB	−47 B (−0.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−40 B (−0.6%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.1 KiB	57.0 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	9	−1 (−10.0%)	21	✅

Baseline: 0c84b42 · PR result: df583d6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes Android fold previews from fixed geometry to source-derived geometry and introduces a new fallback default, affecting sizing, framing, cover rendering, and touch mapping. Because the product default behavior changes, the default geometry warrants human review despite the localized scope and added tests.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: df18b75d-0ab0-46c5-83a6-48e127012660

📥 Commits

Reviewing files that changed from the base of the PR and between 0c84b42 and df583d6.

📒 Files selected for processing (4)

• packages/client-runtime/src/device/androidFoldScene.test.ts
• packages/client-runtime/src/device/androidFoldScene.ts
• packages/client-runtime/src/device/phoneViewer.test.ts
• packages/client-runtime/src/device/phoneViewer.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The Android fold scene now sizes its geometry from an inner-display aspect ratio. The phone viewer derives that ratio from source-canvas dimensions and updates active fold scenes when a valid ratio changes.

Changes

Foldable display aspect

Layer / File(s)	Summary
Aspect-driven fold scene geometry packages/client-runtime/src/device/androidFoldScene.ts, packages/client-runtime/src/device/androidFoldScene.test.ts	The scene accepts an optional inner-display aspect and uses it to size the device panels, screens, camera, keys, and overall width. A test checks the continuous screen bounds against portrait and landscape frame aspects.
Viewer aspect updates and hinge angle packages/client-runtime/src/device/phoneViewer.ts, packages/client-runtime/src/device/phoneViewer.test.ts	The viewer uses a valid source-canvas aspect or the default aspect when creating fold scenes. When the aspect changes on an active fold scene without an imported model, the viewer rebuilds the scene at its visible hinge angle. Tests check landscape sizing and body retention through cover-frame updates.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant SourceCanvas
  participant PhoneViewer
  participant createAndroidFoldScene
  SourceCanvas->>PhoneViewer: Provide dimensions for aspect calculation
  PhoneViewer->>PhoneViewer: Validate aspect and read visible hinge angle
  PhoneViewer->>createAndroidFoldScene: Create or rebuild scene with aspect and angle

Loading

Merge Risk: ⚪ Minimal · up to df583

The foldable viewer appears ready to merge after normal checks; no actionable sizing or hinge-animation issue remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: sizing the Android fold model from the inner display aspect ratio.
Description check	✅ Passed	The description explains what changed, why it changed, verification performed, test coverage, and visual behavior. It does not use every template heading or include a completed checklist, but it is su…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}