Added AllowFieldCountMismatch property to CsvConfiguration - #985
Draft
michelebastione wants to merge 912 commits into
Draft
Added AllowFieldCountMismatch property to CsvConfiguration#985michelebastione wants to merge 912 commits into
michelebastione wants to merge 912 commits into
Conversation
When tabSelected="1", the resulting Excel will say "Cannot do this for multiple selected areas" Signed-off-by: Gary Jia <35099424+jiaguangli@users.noreply.github.com>
…tware#647) * Fixed an issue with QueryAsDataTable that only header rows cannot be read correctly * handling null value
…mplify code (mini-software#651) * feat: 增加 MiniExcelDataReaderBase 基类 * refactor: 使用基类精简代码 * Update MiniExcelDataReaderBase.cs Signed-off-by: Wei Lin <shps951002@gmail.com> --------- Signed-off-by: Wei Lin <shps951002@gmail.com> Co-authored-by: Wei Lin <shps951002@gmail.com>
* Add tests for fast mode * Fix dimension writing in FastMode
mini-software#679) * Formula attribute added to support in rows with dto or dynamic attributes * Change Formula attribute to ColumnType (Value, Formula) --------- Co-authored-by: Eulises Vargas <eulises.vargas@iconstruye.onmicrosoft.com>
…e#681) * Upgrade to .NET 8.0 * Add tests
* Add async implementation of frozen rows and columns * Add unit tests for async implementation of frozen rows and columns * Fix formatting and delete temp file in unit test * move freezing top row implementation to DefaultOpenXml.cs
…ut the value as text. Preventing of losing leading zeroes
* Add AutoWidth functionality for async write * Add MiniExcelAutoAdjustWidthTests * Implement autowidth for sync write
Fix - Missing leading zeros
…ormatting Delegate (mini-software#700) * Add DynamicColumnFirst in config; * Handle DynamicColumnFirst value assign; Modify DynamicColumns ignore case; * Handle CustomFormatter logic;
…e#706) * feat(MiniExcelDataReaderBase): Add asynchronous support * fix `ReadAsync` bug * remove the error submission code * add unit test * optimization cancellation * optimization disposeAsync * optimized code * chore: bump version 1.36.1 * refactor: 格式化代码 --------- Co-Authored-By: Argo Zhang <argo@live.ca>
* feat: support insert sheet * optimize code * fix: async method bug
…iting IAsyncEnumerable (mini-software#712) * Generalize excel writing with a common write adapter * Remove testcase for single row in empty table * Implement sync IExcelWriteAdapter * Remove testcase for single row in empty table * Add back support for writing IMiniExcelDataReader * Add support for writing AsyncEnumerable * Add cancellation support * Add MiniExcelWriteAdapterFactory * Implement write adapters for csv writing * cancel break change * fix build bug * fix get props bug * cancel some adjust * clean code --------- Co-authored-by: izanhzh <hzh990094740@outlook.com>
doc: add insert sheet
…rful (mini-software#715) * feat(DynamicExcelColumn): make the `CustomFormatter` property more powerful * support `IEnumerable` data
* feat(ExcelNumberFormat): extend the SectionType * cancel the missubmit code * Update SheetStyleBuildContext.cs Signed-off-by: Wei Lin <shps951002@gmail.com> --------- Signed-off-by: Wei Lin <shps951002@gmail.com> Co-authored-by: Wei Lin <shps951002@gmail.com>
…atter` execution (mini-software#722) * adjust the location of the `CustomFormatter` execution * fix bug
* Updating sample projects
Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
* Minor xml generation refactoring * Changed sheets and files' ids to be deterministic Generated Excel files are now always consistent when the data source is the same, save for the metadata of the zip entries.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
ChangesCSV jagged-row handling
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/MiniExcel.Csv/CsvReader.cs`:
- Around line 67-133: Update the invalid-row check before the header and
headerless branches to reject any field-count mismatch when
AllowFieldCountMismatch is false, not only rows where fields.Length is less than
headerRow.Count. Preserve the existing ColumnNotFoundException construction and
ensure both hasHeaderRow paths exit through this check before assigning fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f567c7b8-2687-4a1f-bf0f-0c366b9d374b
📒 Files selected for processing (5)
src/MiniExcel.Csv/CsvConfiguration.cssrc/MiniExcel.Csv/CsvReader.cstests/MiniExcel.Csv.Tests/Main/MiniExcelCsvAsyncTests.cstests/MiniExcel.Csv.Tests/Main/MiniExcelCsvTests.cstests/MiniExcel.Csv.Tests/Main/Models.cs
michelebastione
marked this pull request as draft
July 19, 2026 16:01
… and benchmarks projects (mini-software#986) * Added documentation to the MiniExcelConverter utility class * Fixed warnings in tests and benchamrks projects * Minor adjustments
michelebastione
force-pushed
the
csv-jagged-rows
branch
from
July 20, 2026 23:15
87445aa to
d9f95b8
Compare
…tware#988) * Removed unused System.Security.Cryptography.Xml package * Removed some tests of questionable usefulness * Refactored benchmarks sample data * Updated .gitattribtues to treat all tests data files as binary data * Fixed typo
michelebastione
force-pushed
the
csv-jagged-rows
branch
2 times, most recently
from
July 22, 2026 22:00
077f1e6 to
6d1fa3e
Compare
…and stats Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
michelebastione
force-pushed
the
csv-jagged-rows
branch
from
July 22, 2026 22:08
6d1fa3e to
0cdea67
Compare
* Moved FluentMapping logic to its own MiniExcel.OpenXml.FluentMapping assembly This makes it easier to mantain and also makes the main MiniExcel.OpenXml assembly smaller for the users who don't care for the fluent mapping * Updated System.Security.Cryptography.Xml package Manually added latest version of the package where NPOI brought in a vulnerable one * Minor fixes
* Added CODE_OF_CONDUCT.md and CONTRIBUTING.md files * Minor fixes
…penXml) (mini-software#993) * Fix template calcChain regeneration and $= formula cells (v2 / MiniExcel.OpenXml) Porting the v1.x template-render fixes to the v2 OpenXml line, where the engine moved to src/MiniExcel.OpenXml/ and a LINQ-to-XML rewrite. Two defects made Excel reject an otherwise-valid rendered package: - $= formula cells kept their source t="inlineStr" attribute after the inline string was replaced with an <f> child — a cell typed inlineStr with no <is> is schema-invalid. The attribute is now removed. - The regenerated calcChain entry took the cell address from the running child-index, which is wrong for sparse rows (cells with no content are not emitted, so position != column). The address is now read from the cell's own r attribute. - The template's own calcChain was reused/copied even though row insertion shifts every formula cell, leaving stale entries; and an empty calcChain (no rendered formulas) was written, which is schema-invalid. The chain is now regenerated only when formulas were rendered and dropped entirely otherwise — Excel rebuilds it on open. The <f> namespace fix from the v1 change is not needed here: v2's XElement-based serialization already emits it in the spreadsheetml namespace. * Removed obsolete FluentMapping folder from project * Converted usage of some raw strings to typed constants * Changed the ProcessFormulas method to calculate cell references based on the full "r" attribute when available * Added regression tests for new handling of calcChain data * Minor fix in the generation of the path/name map for the sheets * Removed ghost calcChain references across the generated package Added logic to remove calcChain references from [Content_Types].xml and workbook.xml.rels when the calcChain is not to be copied from the template's archive. * Fixed minor issue with the extrapolation of calcChain references --------- Co-authored-by: Michele Bastione <michele.bastione@gmail.com>
- Add error handling with custom error types in `error.rs`. - Create core library structure in `lib.rs` with modules for cell handling, error management, options, reading, writing, and serialization helpers. - Define `ReadOptions` and `WriteOptions` in `options.rs` for configuring read/write behavior. - Implement `XlsxReader` in `reader.rs` for reading XLSX files, including dynamic row handling and deserialization. - Add serialization helpers in `serde_helpers.rs` for date, time, and duration types. - Implement `XlsxWriter` in `writer.rs` for writing XLSX files, including schema validation and cell formatting. - Create common test utilities in `common/mod.rs` for file path handling. - Add tests for reading dynamic and typed rows, handling empty rows, and round-trip writing/reading of XLSX files. - Set Rust toolchain version and formatting options in `rust-toolchain.toml` and `rustfmt.toml`.
- Introduced a new `MiniExcel` struct as a convenience entry point for querying XLSX files. - Implemented `StreamingRows` and `StreamingTypedRows` for efficient row streaming and deserialization. - Updated tests to utilize the new `MiniExcel` API for querying and validating data from XLSX files. - Enhanced error handling in streaming operations and added support for dynamic row reading. - Refactored existing code to integrate with the new streaming architecture, improving performance and memory usage.
…dules - Removed unused imports and types from `lib.rs`, including `WriteSummary` and various reader types. - Changed visibility of several methods in `ReadOptions` and `WriteOptions` to `pub(crate)`. - Simplified `XlsxReader` and removed the `DynamicRows` and `TypedRows` structs, consolidating functionality. - Updated `serde_helpers` to include new serialization functions for date types. - Modified `StreamingRows` and `StreamingTypedRows` to use updated error handling. - Refactored `XlsxWriter` to remove `WriteSummary` and adjust method signatures for consistency. - Updated tests to reflect changes in the API, ensuring compatibility with the new structure.
- Added `serde_json` as a dependency in `Cargo.toml`. - Updated README files to include .NET parity contract information and testing instructions. - Introduced a new JSON contract file for shared behavior between .NET and Rust. - Implemented Rust tests for dynamic and typed queries to match .NET contract. - Enhanced memory handling in the streaming path of the OOXML reader. - Updated tests to reflect changes in expected row counts and empty row handling. - Created new C# tests for compatibility with Rust's parity contract.
…ADME documentation
Add byte-oriented XLSX read/write support and tests, expose it through a browser WASM adapter, add the responsive web demo with Playwright coverage, and deploy the generated site through GitHub Pages Actions.
- Introduced a new GitHub Actions workflow for browser wasm builds and tests. - Enhanced README files to document new features including inclusive A1 start/end ranges and browser WebAssembly adapter. - Updated `ReadOptions` to support an optional end cell for dynamic queries. - Implemented validation for cell ranges to ensure end cell does not precede start cell. - Added new tests for inclusive cell range queries and error handling for invalid ranges. - Updated web demo to include end cell input and corresponding functionality in the UI. - Bumped Playwright version in web demo dependencies for improved testing capabilities.
The implementation of this property makes jagged rows being returned as they are instead of having an exception being thrown when a mismatched number of fields is found.
michelebastione
force-pushed
the
csv-jagged-rows
branch
from
August 18, 2026 17:16
0cdea67 to
c6b632f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of this property makes jagged rows being returned as they are instead of having an exception being thrown when a mismatched number of fields is found.
Resolves #979
Summary by CodeRabbit
New Features
Bug Fixes
Deprecation