Fix @group tag not working with certain IEnumerable types - #723
Merged
Conversation
Member
|
@JamesDSource Merged 🙌, and e-mail invitation for you, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the IEnumerable type can't be casted to an IList, such as a List of structs, xRowInfo.CellIlListValues will silently be NULL. To fix, I check if it can be casted to IList first, then create one from CellIEnumerableValues if it can't. Later in generating a template, this issue would have caused a NullReferenceException when parsing the @endgroup tag.
Removed a redundent check for
cellValue is IList<object>, because all IList types are IEnumerable.Added a test for groups that would trigger a NullReferenceException before this patch.