Fix dimension writing in FastMode - #659
Merged
Merged
Conversation
Contributor
Author
|
Seems like i have a few things to fix first 😄 |
Discolai
marked this pull request as draft
August 23, 2024 10:57
Discolai
force-pushed
the
bug-fast-mode
branch
from
August 23, 2024 11:10
5e661b5 to
ef612ec
Compare
4 tasks
Discolai
marked this pull request as ready for review
August 23, 2024 11:14
shps951023
approved these changes
Aug 25, 2024
Member
|
@Discolai ❤ Merged |
pull Bot
pushed a commit
to zilo555/MiniExcel
that referenced
this pull request
Aug 29, 2026
* Add tests for fast mode * Fix dimension writing in FastMode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent refactoring in #602 broke excel writing in FastMode if the input collection was an
IEnumerable.The issue was caused by a missing call to reset the position after seeking back to overwrite the placeholder