Fix dev-tools-update path validation: expand ~ before checking paths

[jeonghun-jj-lee]

Summary

Three fixes to the extension-side dev-tools-update/dev-tools-rebuild handlers in chat_bridge.ts, all part of a broader settings-dialog bug sweep paired with harmoniqs/opencode#318.

1. Path validation false negatives (tilde expansion)

The handler validated the opencode/amicode repo paths with fs.statSync but never expanded a leading ~, so the default settings paths (~/harmoniqs/opencode, ~/harmoniqs/amicode) always failed validation even when they pointed at a real, valid repo — Node's fs module doesn't resolve ~ on its own. The sibling dev-tools-rebuild handler already expanded tildes; this brings dev-tools-update in line with it.

Fix: Added .replace(/^~/, os.homedir()) to both path reads.

2. Committing a path silently triggered a real build + window reload (#941)

Blurring either path field re-sends BOTH current path values (the app's sendUpdate() always includes both), and the handler unconditionally ran a real bun run build + an unconfirmed workbench.action.reloadWindow whenever the amicode path was valid and non-empty. So even an unrelated edit to the opencode field — or just re-blurring an unchanged, already-valid amicode path — silently rebuilt and reloaded the whole window with no confirmation.

Fix: Committing the amicode path is now validate-only, same as the opencode path already was. Building is exclusively an explicit action via the existing "Rebuild Locally" / "Rebuild from Main" buttons.

3. A valid opencode repo path was rejected identically to a typo (#943)

The candidate list for resolving a fork checkout's built binary only ever checked an unsuffixed dist/opencode/bin/opencode path — but every real fork build produces a platform-suffixed directory instead (dist/opencode-darwin-arm64/bin/opencode, etc.). So a genuinely valid repo path was rejected with "Binary not found at this path" exactly like an actual typo — correcting a bad path to a real one just re-ran the same broken check and got the same wrong answer, which reads as "it doesn't update." This predates this PR entirely (introduced in the original Developer Tools feature).

A second, separately-incomplete candidate list existed in dev-tools-rebuild's post-build resolve step (darwin-only, missing both Linux targets).

Fix: Extracted one shared findForkedOpencodeBinary() helper in opencode_binary.ts, built from the canonical SUPPORTED platform list, used by both handlers. Also fixes a latent bug in the original inline loop: mutating a shared reply object across iterations meant an earlier existing-but-not-executable candidate could permanently mark opencodeValid false even if a later candidate resolved successfully.

Testing (TDD)

Each fix has its own failing-first test:

• Tilde expansion: exercised via a real symlink under the home directory.
• Auto-build removal: asserts a valid amicode-path commit produces exactly one synchronous status reply with no building/reloadNeeded and no devAssetRoot config write.
• Platform-suffixed binary: new unit tests for findForkedOpencodeBinary (platform-suffixed resolution, legacy-layout fallback, not-found vs. not-executable, direct-binary-path, and the earlier-bad-candidate-doesn't-shadow-a-later-good-one regression), plus an integration test reproducing the exact reported bug — a fork checkout with only a platform-suffixed layout, matching a real ~/harmoniqs/opencode checkout.

All confirmed RED before their fix, GREEN after.

pnpm --filter amicode test  →  3079/3079 pass

Side benefit: the auto-build removal also fixes a latent issue in the tilde-expansion tests, which incidentally spawned a real, doomed bun run build child process against a fake temp repo before that fix.

Companion PR

This is the extension-side half of a broader settings-dialog bug sweep. The app-side fixes (rebuild label, rebuild status flags, validation flicker, permissions-tab relocation, header alignment, and the companion dead-code cleanup) are in the paired fork PR: harmoniqs/opencode#318.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 35c00e84-d164-4764-b150-9ad2e94fc0e3

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}