docs: ADR 0013 + CONTEXT.md — Preview becomes a split-pane workspace - #941
Merged
Merged
Conversation
Preview redefines from a single-file companion viewer into a multi-document workspace: inner file tabs, breadcrumb sibling navigation, and recursive edge-drop split panes. Design-of-record: #940. - ADR 0013 documents the decision and the three approaches considered - CONTEXT.md Preview + Sidebar entries updated to the workspace definition
jeonghun-jj-lee
added
the
documentation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 9, 2026
Blurring either Developer Tools path field re-sends BOTH current path values (sendUpdate() always includes both), and the dev-tools-update handler unconditionally ran a real 'bun run build' + an unconfirmed 'workbench.action.reloadWindow' whenever the amicode path was valid and non-empty — so even an unrelated edit to the opencode field, or just re-blurring an unchanged value, silently rebuilt and reloaded the whole window. Committing a path is now validate-only for both fields: opencode still swaps the binary + restarts just the server (lightweight, non-disruptive, left as-is), and amicode now only checks the path looks like a real repo. Clearing the amicode path to empty still clears any devAssetRoot override — that's removing a setting, not building one. Building is now exclusively an explicit action via the existing 'Rebuild Locally' / 'Rebuild from Main' buttons (a separate dev-tools-rebuild message, already self-sufficient and unaffected by this change). TDD: added a test asserting a valid amicodePath commit produces exactly one synchronous status reply with no building/reloadNeeded and no devAssetRoot config write. Confirmed RED against the old code (it eagerly posts building:true before any real build attempt completes, which is what the interim message the test caught was). Applied the fix, confirmed GREEN (41/41). Side benefit: this also fixes a latent issue in the existing tilde-expansion tests, which incidentally spawned a real, doomed 'bun run build' child process against a fake temp repo before this fix.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only PR: pins down the design-of-record for #940 (Preview workspace — multi-file tabs, breadcrumb navigation, and split panes) in the repo's durable records ahead of implementation, per the established convention (ADR 0006, ADR 0009).
SessionPreviewTabdoes not).CONTEXT.md—PreviewandSidebarglossary entries updated to describe the workspace model (inner tabs, breadcrumb, recursive split panes) instead of the single-file companion viewer.Source
Design-of-record: #940