Skip to content

Sync app overlay from merged opencode local/amicode - #947

Merged
jeonghun-jj-lee merged 1 commit into
mainfrom
chore/sync-app-overlay-318
Sep 10, 2026
Merged

Sync app overlay from merged opencode local/amicode#947
jeonghun-jj-lee merged 1 commit into
mainfrom
chore/sync-app-overlay-318

Conversation

@jeonghun-jj-lee

Copy link
Copy Markdown
Contributor

Summary

Records the merged harmoniqs/opencode local/amicode snapshot in Amicode's committed app overlay and updates packages/app-bundle/manifest.json hashes.

This is the required one-way fork → overlay tracking update after harmoniqs/opencode#318 merged. The fork remains the app-layer source of truth; the overlay is the committed snapshot used by Amicode's bundle/materialization pipeline.

Included fork changes:

Verification

Ran the official sync and drift check against the merged fork source:

AMICODE_OPENCODE_SRC=/Users/jj/harmoniqs/opencode \\
  node packages/app-bundle/scripts/overlay-sync.mjs --apply

AMICODE_OPENCODE_SRC=/Users/jj/harmoniqs/opencode \\
  node packages/app-bundle/scripts/overlay-sync.mjs --check
# PASS: all 611 fork-tracked overlay files match the fork

AMICODE_OPENCODE_SRC=/Users/jj/harmoniqs/opencode \\
  node packages/app-bundle/scripts/drift_gate.mjs
# PASS: overlay and manifest are in sync

The 15 overlay-only files reported by the tool are retained intentionally; overlay-sync does not delete them.

Related

Refresh the committed fork tracking copy and its manifest from the merged
harmoniqs/opencode local/amicode source. This captures the settings-dialog
Developer Tools/Permissions changes from opencode#318, the prompt-input
and directory-sync updates already present in the fork, all matching i18n
keys, and the final baseline-alignment CSS correction.

Verified with the official one-way overlay sync and drift gate:
AMICODE_OPENCODE_SRC=/Users/jj/harmoniqs/opencode node
packages/app-bundle/scripts/overlay-sync.mjs --check
reports all 611 fork-tracked overlay files match, and drift_gate.mjs
passes manifest integrity.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e6d8c820-409d-4417-b06c-2ff017b0553e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeonghun-jj-lee
jeonghun-jj-lee merged commit ff7b69c into main Sep 10, 2026
9 of 10 checks passed
jack-champagne pushed a commit that referenced this pull request Sep 11, 2026
Automates the diff JJ has been generating by hand (#947, #1005, #1006,
#1009, #1011): on a schedule (or manual dispatch), run the existing
overlay-promotion.mjs --check against the fork's local/amicode tip, and
on drift, run --apply on a deterministic review branch and open/update
one PR.

Deliberately not built: a signed webhook receiver, a GitHub App,
compare-and-swap bot-merge authority, or exception-approval automation.
JJ's own promotion PRs (#1009, #1011) were merged 6-27 seconds after
opening once CI was green — the toil is producing the diff, not
reviewing it, so a human (or required status checks) still merges here.

Verified locally against a scratch git remote + the real
harmoniqs/opencode clone (not just described):
  - --check against the current in-sync state exits 0, no PR opened
  - a simulated fork commit drifts --check to exit 1
  - --apply on the review branch (created BEFORE --apply, since #1005's
    main-branch guard would otherwise refuse it) reproduces the correct
    manifest + overlay diff
  - re-running --apply after resetting the branch from main is
    idempotent (same tree each time, safe to force-push)

If the app-bundle overlay is retired later (tracked separately, off
#1010), this workflow is deleted, not migrated.
jack-champagne added a commit that referenced this pull request Sep 11, 2026
… bot (#1010 Phase 0+1) (#1025)

* fix(app-bundle): resolve upstream_base as commit SHA, not tag

manifest.upstream_base has held a commit SHA (not a tag) since recent
promotions started passing --base <sha> to overlay-promotion.mjs, but
materialize.mjs and drift_report.mjs both built the upstream fetch URL
under refs/tags/, which 404s for a SHA. This has been failing vsix-gate
on main since #1011. GitHub's /archive/<ref>.tar.gz endpoint resolves
both tags and commit SHAs through the same path, so drop refs/tags/.

Also scope overlay-promotion.mjs's main-branch promotion guard (#1005)
to the real overlay/manifest paths only. It was checking this repo's
current branch unconditionally, which correctly blocks a human running
--apply directly on main, but also blocked overlay_promotion.test.ts's
own --apply exercise (run via a custom --target/--manifest fixture,
never the live overlay) whenever CI happened to run on main — which is
every push to main, including this one. That's the second failure in
the same CI run.

* feat(ci): add overlay-promotion-bot workflow (#1010 Phase 1)

Automates the diff JJ has been generating by hand (#947, #1005, #1006,
#1009, #1011): on a schedule (or manual dispatch), run the existing
overlay-promotion.mjs --check against the fork's local/amicode tip, and
on drift, run --apply on a deterministic review branch and open/update
one PR.

Deliberately not built: a signed webhook receiver, a GitHub App,
compare-and-swap bot-merge authority, or exception-approval automation.
JJ's own promotion PRs (#1009, #1011) were merged 6-27 seconds after
opening once CI was green — the toil is producing the diff, not
reviewing it, so a human (or required status checks) still merges here.

Verified locally against a scratch git remote + the real
harmoniqs/opencode clone (not just described):
  - --check against the current in-sync state exits 0, no PR opened
  - a simulated fork commit drifts --check to exit 1
  - --apply on the review branch (created BEFORE --apply, since #1005's
    main-branch guard would otherwise refuse it) reproduces the correct
    manifest + overlay diff
  - re-running --apply after resetting the branch from main is
    idempotent (same tree each time, safe to force-push)

If the app-bundle overlay is retired later (tracked separately, off
#1010), this workflow is deleted, not migrated.

---------

Co-authored-by: Test <test@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant