skills-integrity: vault-path reference doctrine lands in its owner (F28 vault half) - #1105
Merged
Merged
Conversation
One section in the mount rules of the vault constitution: reference mounts by role (personal by role, team by kind, ops tree as $AMICO_OPS), never by name or raw home path — the 2026-08-21 personal-vault rename is the proof case. Notes the skills lint's [vpath] rule as the mechanical enforcement of the error class. F28 vault half (lint half rides #1100).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
marked this pull request as ready for review
September 13, 2026 22:16
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 14, 2026
…octrine fix(skills-lint): exempt F28 doctrine owner's own vpath proof-case (main-red regression from #1105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The vault half of F28: the vault-path reference doctrine now lives in its owner — one section in
amico-vault's mount rules (the vault constitution), not scattered as convention.Landed section —
packages/extension/skills/amico-vault/SKILL.md, new### Vault-path references (role, not name)under Mounts & resolution:armonissimamay appear in an example, labeled as an instance, never as the identifier.$AMICO_OPS/….vault-aaron→armonia-aaron-trowbridge), whose aftermath (clients silently riding the rename redirect) is exactly the silent rot the rule prevents.Plus a closing note that the skills lint's
[vpath]rule (#1100, in flight — the lint half of F28) enforces the known-rotted shapes mechanically.Why this shape
amico-vaultcard is the owner, vault-side PRs cannot carry it.surface: public): the section reads as product documentation — no session IDs, no finding numbers in the card body. The rename's directory names appear only as the historical evidence of the proof case (the same carve-out PR build(deps-dev): bump the dev-dependencies group across 1 directory with 5 updates #98 made for the fleet postmortem); no live path in the card embeds a vault or repo name.fleetcard" pointer was dropped — that card is vault-side (armonissima/skills/fleet) and would dangle in this repo's shipped skill bundle.Verification
pnpm --filter amicode test: 3468 passed / 10 failed / 48 skipped — the failure set is the known environmental set, identical on pristineorigin/main(verified by stash-and-rerun):amicode_service_runner×1,chat_bridge×2,skill_drift_lint×2 (fleet-package regressions),cli_gate×1,main_source_resolver×2,rebuild_coordinator×2. Zero new failures from this change. (One run flaked 9→10 on the same set — a 5s timeout in one environmental test.)node packages/extension/scripts/lint-skills.mjs: output byte-identical pre/post change (27 pre-existing companion errors onorigin/main, none inamico-vault). The[vpath]rule is absent on this branch — it is skills-integrity lint: [vpath] rotted vault-path rule (F28 repo half) #1100's, noted in the card and enforced once that lands.Draft per the walk's rules — the parent owns merge and integration.