Skip to content

skills-integrity: vault-path reference doctrine lands in its owner (F28 vault half) - #1105

Merged
aarontrowbridge merged 1 commit into
mainfrom
aaron/f28-vault-path-doctrine
Sep 13, 2026
Merged

aarontrowbridge merged 1 commit into
mainfrom
aaron/f28-vault-path-doctrine

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

What

The vault half of F28: the vault-path reference doctrine now lives in its owner — one section in amico-vault's mount rules (the vault constitution), not scattered as convention.

Landed section — packages/extension/skills/amico-vault/SKILL.md, new ### Vault-path references (role, not name) under Mounts & resolution:

  1. Personal mount by ROLE — "the personal vault", resolved from the mount stack — never by its directory or marker name.
  2. Team mount by KIND — "the team mount"; armonissima may appear in an example, labeled as an instance, never as the identifier.
  3. Ops tree only as $AMICO_OPS/….
  4. Never a raw home path embedding a vault or repo name in prose or examples — proof case cited: the 2026-08-21 personal-vault rename (vault-aaron → armonia-aaron-trowbridge), whose aftermath (clients silently riding the rename redirect) is exactly the silent rot the rule prevents.

Plus a closing note that the skills lint's [vpath] rule (#1100, in flight — the lint half of F28) enforces the known-rotted shapes mechanically.

Why this shape

Verification

  • pnpm --filter amicode test: 3468 passed / 10 failed / 48 skipped — the failure set is the known environmental set, identical on pristine origin/main (verified by stash-and-rerun): amicode_service_runner ×1, chat_bridge ×2, skill_drift_lint ×2 (fleet-package regressions), cli_gate ×1, main_source_resolver ×2, rebuild_coordinator ×2. Zero new failures from this change. (One run flaked 9→10 on the same set — a 5s timeout in one environmental test.)
  • node packages/extension/scripts/lint-skills.mjs: output byte-identical pre/post change (27 pre-existing companion errors on origin/main, none in amico-vault). The [vpath] rule is absent on this branch — it is skills-integrity lint: [vpath] rotted vault-path rule (F28 repo half) #1100's, noted in the card and enforced once that lands.

Draft per the walk's rules — the parent owns merge and integration.

One section in the mount rules of the vault constitution: reference
mounts by role (personal by role, team by kind, ops tree as
$AMICO_OPS), never by name or raw home path — the 2026-08-21
personal-vault rename is the proof case. Notes the skills lint's
[vpath] rule as the mechanical enforcement of the error class.

F28 vault half (lint half rides #1100).
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 311b6d4b-f607-4961-a3fa-f5d33b76217a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aarontrowbridge
aarontrowbridge marked this pull request as ready for review September 13, 2026 22:16
@aarontrowbridge
aarontrowbridge merged commit 35c169c into main Sep 13, 2026
10 checks passed
jeonghun-jj-lee added a commit that referenced this pull request Sep 14, 2026
…octrine

fix(skills-lint): exempt F28 doctrine owner's own vpath proof-case (main-red regression from #1105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant