fix(skills-lint): exempt F28 doctrine owner's own vpath proof-case (main-red regression from #1105) - #1121
Merged
Conversation
test/skills_integrity.test.ts is red on main: the [vpath] rule (PR #1105) flags amico-vault/SKILL.md:108 — the doctrine's own proof-case citing the vault-aaron -> armonia-aaron-trowbridge rename. #1105 shipped the rule and the doctrine content together but never allowlisted the self-citation. Exempt the doctrine owner's vpath findings via the designed --known escape hatch (a deliberate citation, not rot). NEW vpath rot in any OTHER skill still fails. Closes #. Verified: lint 0 errors/exit 0; skills_integrity 10/10; fast suite 224/224.
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 14, 2026
…+ skills-lint #1121 # Conflicts: # packages/app-bundle/manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
fastCI regression onmain(test/skills_integrity.test.ts).Root cause
PR #1105 (
aaron/f28-vault-path-doctrine) landed the[vpath]lint rule and the doctrine content that trips it —amico-vault/SKILL.md:108, which cites thevault-aaron→armonia-aaron-trowbridgerename as its proof case — but never allowlisted that self-citation. The rule's owner file thus fails its own lint (1 error → exit 1), reddeningmain.Fix
One line in
scripts/lint-skills-known.txt: exemptamico-vault/SKILL.md:vpath(with a comment). The occurrence is a deliberate documented citation, not rot — and--knownis the tool's designed escape hatch. NEW vpath rot in any other skill still fails (vpath exemptions are per-file; the doctrine owner is the one file that must cite the shapes it teaches).Verification (local)
node scripts/lint-skills.mjs --dir skills --known scripts/lint-skills-known.txt→ 0 errors, exit 0test/skills_integrity.test.ts→ 10/10Ref: #1120