Skip to content

skills-integrity lint: [vpath] rotted vault-path rule (F28 repo half) - #1100

Merged
aarontrowbridge merged 1 commit into
mainfrom
aaron/issue-f28-vpath-lint
Sep 13, 2026
Merged

aarontrowbridge merged 1 commit into
mainfrom
aaron/issue-f28-vpath-lint

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

What

Finding F28 (vault-path doctrine): skills referenced vaults by at least four idioms and the disease was unowned — the 2026-09-13 campaign fixed five instances of it (dream-state, dream-journal, linkedin example path, sota-review ledger line, dream-family routing), none guarded. This is the repo half of the fix shape: the standing tooth in lint-skills.mjs.

The rule

[vpath] — rotted vault-path shapes in SKILL.md, house style with the existing four rules, zero deps:

  • ERRORS (fail the lint), literal shapes anywhere in the file: amico/vault/ (old ops-repo path), vault-aaron (pre-rename personal vault name), ~/.claude/ (retired transcript substrate).
  • WARNINGS (never fail) for the rot-prone class: raw home paths embedding vault names, ~/…(vaults|armonia-data)…/ — the shape that rotted once already with the armonia-aaron-trowbridge rename.
  • vpath joins the --known RULES set, so exemptions work exactly as for the other rules. No entries needed: lint-skills-known.txt is unchanged — the tree at origin/main is clean of the error shapes (director-verified; re-verified here).

Verification

  • test/skills_integrity.test.ts: 4 new cases — planted error shapes fail with file+line per shape; warning shape exits 0 with [vpath] warning: output; --known exemption turns the error into a known-warning; the real tree is asserted clean of [vpath] errors and green end-to-end. 10/10 pass in the file (6 pre-existing + 4 new).
  • Real tree: 35 skills, 0 errors, 6 warnings (~/.amico/vaults/ prose in amico-schema-check, amico-vault, brainstorming, promote — the doctrine's rot-prone class, flagged but non-failing), exit 0.
  • Full pnpm --filter amicode test: 3472 passed / 9 failed / 49 skipped (3530 total; 218/223 files). All 9 failures are the pre-existing environmental set (amicode_service_runner, chat_bridge ×2, cli_gate, main_source_resolver ×2, rebuild_coordinator ×2, skill_drift_lint — timeout-flaky, 10 on re-run) — baseline-verified: the same files fail identically on a clean tree without this diff. Not chased, per the brief.

Out of scope / notes

  • The amico-vault constitution section (fix shape (a)) is the vault half of F28, separate.
  • Pre-existing quirk noticed while writing fixtures (not touched here): the companion rule treats backticked ~/….md refs as resolvable companions — a ~/-prefixed path can error as a dead companion. My fixtures avoid .md suffixes to stay surgical to [vpath].

DRAFT — not ready for review; the walk owns merge and terminus.

Finding F28 (vault-path doctrine): skills referenced vaults by four idioms
and the disease was unowned — five instances of it fixed on 2026-09-13, none
guarded. This adds the standing tooth to lint-skills.mjs, house style with
the existing four rules, zero deps:

- [vpath] ERRORS for the rotted literal shapes anywhere in a SKILL.md:
  `amico/vault/` (old ops-repo path), `vault-aaron` (pre-rename personal
  vault name), `~/.claude/` (retired transcript substrate).
- [vpath] WARNINGS (never fail) for the rot-prone class per the doctrine:
  raw home paths embedding vault names
  (~\/...(vaults|armonia-data)...\/) — the shape that rotted once already
  with the armonia-aaron-trowbridge rename.
- `vpath` joins the --known RULES set (path:rule exemptions work as for the
  other rules); no known entries needed — the real tree is clean of the
  error shapes and lint-skills-known.txt needs no change.

Real tree at origin/main: 35 skills, 0 errors, 6 warnings (~/.amico/vaults/
prose in amico-schema-check, amico-vault, brainstorming, promote), exit 0.

Tests (skills_integrity.test.ts): planted error shapes fail with file+line;
warning shape exits 0 with warning output; --known exemption turns the
error into a known-warning; the real tree is asserted clean of [vpath]
errors and green end-to-end.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 379333a7-675a-4ec8-8e22-7c5a06ca44a1


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant