fix: restore main CI — platform-aware installer test + the F28 doctrine obeys its own rule (#1109 follow-up) - #1130
Merged
Merged
Conversation
…in skips the host check by design) + the F28 doctrine obeys its own rule (#1109 follow-up) CI's ubuntu runner exposed two darwin-blind spots merged in #1109's window: (1) the installer fleet-branch test asserted darwin's terminal outcome (guard not installed, exit 1) — on non-darwin the installer deliberately skips the host check ('the fleet is a darwin fleet') and completes green; the test now asserts the BRANCH (parsed role, never the standalone skip) and accepts the platform's correct terminal outcome. (2) amico-vault's F28 proof case embedded the literal rotted vault names — the doctrine violated its own 'never in prose or examples' rule and its own mechanical lint caught it; reworded, with the self-obedience stated.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores main's fast lane — #1109's merge run failed on two darwin-blind spots my local gates (darwin) could not see:
--checkgreen. The test now asserts the BRANCH (the parsed role + port flowed through; never the standalone skip) and accepts the platform's correct terminal outcome — darwin: exit 1 + guard-not-installed; non-darwin: exit 0 + host-check-skipped. Read straight from install.sh's ownunamebranch.[vpath], the skills campaign's skills-integrity lint: catch retired namespaces, dead skill paths, and frontmatter drift in CI #1045/skills-integrity lint: [vpath] rotted vault-path rule (F28 repo half) #1100) correctly caught it. Reworded without the literals, with the self-obedience stated — the lint cannot tell a proof case from a violation, and that is the point.Gate evidence: both suites green locally (28/28); typecheck clean. The third CI red in #1109's run (skills_integrity's second test) is the same F28 finding — one fix covers both. The two amico-run profile_verb failures in the same window are the known deploy-lag family (machine-specific, CI-green — not this PR's concern).
Process note, on the record: #1109 was merged on a partial CI view (the long-pole lanes green in the tail; the run conclusion checked after the merge — backwards). The run-conclusion check now happens BEFORE merge, every time. The skills_integrity failures are the skills campaign's surface — fixed here minimally to unblock main; the owning agent may rework the doctrine further.