Repository navigation
tools: ledger the three LinkSection constructor copies (Refs #7490) - #7864
Merged
Merged
Conversation
Duplicate Body Ratchet is red on master (16:45Z, 16:57Z, 17:10Z pushes): three fresh 2-copy groups, LinkSection_text / LinkSection_data / LinkSection_bss. Cause: #7490 (a6d4e55) unified LinkSection in specs/port/bootstrap/src/compiler/LinkSection_text.t27, whose three constructors return byte-identical bodies to specs/fpga/linker.t27's link_text / link_data / link_bss -- the same ELF section facts (.text flags 5, .data flags 3, .bss flags 2, align 4) written as per-module helpers in two places. Both copies are correct and deliberate; the group is ledgered, not deduped. Ledger diff = exactly three lines. Verified with dupe_scan.py on master head 14e1c7b. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 8, 2026 17:20
This was referenced Oct 8, 2026
Merged
Contributor
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
duplicate-bodies stays red on master after #7864 because of `assign 3`; the same line as #7874, which no-ops once it lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
The previous commit wrote an empty tools/duplicate_bodies_baseline.txt (a git show of a branch that was not fetched). This restores it: master's ledger plus the four lines of #7864 and #7874, nothing else (dupe_scan: ok). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
gHashTag
added a commit
that referenced
this pull request
Oct 8, 2026
…7887) Duplicate Body Ratchet went red on master again within minutes of #7864: the assign group grew to 3. specs/port/trios/crates/trios-server/src/mcp_endpoints/tasks.t27 (port of the trios server MCP endpoints, #7102) stubs all three of assign / status / update_status with the same canned reply, TaskReply{task_id: "task-123", status: "assigned"}. #7491's type renames unified the reply type so the three bodies became identical text for the scanner. The copy is the port as written -- three endpoints, one stub each. Ledgered, not deduped: giving each endpoint a distinct body is the port lane's work (#7102 follow-up), and when they diverge the group shrinks out of the ledger. Ledger diff = exactly one line (assign 3). Verified with dupe_scan.py on master head 7c88448. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
The ledger takes master's entries; dump_ledger drops the counts. The duplicate-bodies lines this branch carried are on master now (#7864, #7887). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
The ledger takes master's entries; dump_ledger drops the counts. The duplicate-bodies lines this branch carried are on master now (#7864, #7887). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Duplicate Body Ratchet is red on master (16:45Z / 16:57Z / 17:10Z pushes, first failing SHA
a6d4e558e3). Three fresh 2-copy groups:This PR ledgers them — diff is exactly three lines in
tools/duplicate_bodies_baseline.txt.Cause
#7490 unified LinkSection in
specs/port/bootstrap/src/compiler/LinkSection_text.t27; its three constructors return byte-identical bodies tospecs/fpga/linker.t27'slink_text/link_data/link_bss— the same ELF section facts (.text flags 5, .data flags 3, .bss flags 2, align 4) written as per-module helpers in two places. Both copies are correct and deliberate; the group is ledgered, not deduped.Verification
dupe_scan.py --blesson master head14e1c7be9; ledger diff verified to contain only the three intended lines.🤖 Generated with Claude Code