Skip to content

t27b checked: test blocks for 7 specs in specs/functions (1 of 5) - #6733

Open
gHashTag wants to merge 2 commits into
masterfrom
queen-6479
Open

gHashTag wants to merge 2 commits into
masterfrom
queen-6479

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Closes #6479

Written by a bee on queen-6479 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

7 files changed, 49 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 5, 2026 16:24
Each spec now has exactly 4 assert statements comparing constants declared in the spec with their literal values, ensuring these specs count toward t27b runtime coverage instead of being pass_vacuous.

Closes #6479
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #6479

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 11:08:12 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 38
PRs with All Checks Green 12
READY 4
FAILING 38
PENDING 0
NO CHECKS YET 0

These columns do not partition: 4 + 38 + 0 + 0 = 42, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=3c78f3c7ffb7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026

@t27-bees t27-bees Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head 04ca3ae50dae37a2b5b844fe413465c3466352d0 (tools/bees/reviewer.py, zai glm-4.7-flash, glm-4.5-flash, 13 turns, 287 s).

BEE-VERDICT: REQUEST_CHANGES
summary: PR successfully adds test blocks but misses t27b-blog entry requirement
criterion: "FR-006" -- unmet -- PR body missing required t27b-blog: +7 <spec paths> entry to document increased coverage
discounted-check: spec-guards -- failure already exists on master (drifted rings unrelated to this PR)
blocking-check: t27b-blog format -- PR body does not include the required t27b-blog: +7 <spec paths> entry for documenting coverage increase

Evidence

Based on my analysis of the PR, here's my verdict:

Evidence Summary

  1. Requirements Met:

    • FR-001: ✅ Exactly one test block added to each of the 7 specified specs
    • FR-002: ✅ Each test has exactly 4 assert lines comparing declared constants
    • FR-003: ✅ All tests pass (verified by runner commands)
    • FR-04: ✅ Files stay ASCII-only
    • FR-05: ✅ PR contains only the specified .t27 files
  2. Issue Requirements Met:

    • All 14 success criteria passed (test-report commands print 2, grep commands print at least 4)
    • Boundary respected: Only the 7 specified specs were modified
    • Test blocks properly assert declared constants using ==, !=, <, <=, >, >=
  3. Missing t27b-blog Entry:

    • ❌ FR-006 not met: The PR body doesn't include t27b-blog: +N <spec paths>
    • The docs/now/2026-10-06 entry is present but doesn't contain the required t27b-blog format
  4. Red Check Analysis:

    • spec-guards failure exists but was already failing on master (same reason: drifted rings)
    • This is a pre-existing issue, not introduced by this PR

BEE-VERDICT: REQUEST_CHANGES

@gHashTag

gHashTag commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

This branch conflicts with master on specs/functions/crm-proactive-sweep.t27, a real content conflict that GitHub's update-branch cannot resolve (checked with git merge-tree against master at 2026-10-07 ~16:10Z). It is left open for conflict_step (#7571), which redoes it from fresh master once the wiring (#7573) lands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t27b checked: test blocks for 7 specs in specs/functions (1 of 5)

2 participants