Skip to content

specs/vsa: write the '≈' check and the C-style loop in t27 so they are not discarded - #5739

Merged
dmitrii-f-t27 merged 1 commit into
masterfrom
fix/vsa-dialect-checks
Oct 3, 2026
Merged

dmitrii-f-t27 merged 1 commit into
masterfrom
fix/vsa-dialect-checks

Conversation

@dmitrii-f-t27

Copy link
Copy Markdown
Collaborator

Closes #5738

Two VSA checks were written in notation the t27 parser does not read, so they were silently discarded.

  • packed_vsa.t27 test packed_cosine_self_similarity_is_one: then sim ≈ 1.0 -> then abs(sim - 1.0) < 1e-6 (comment says what "approximately" means). On master t27c gen emitted this test with an empty body; now it computes and asserts.
  • sdk.t27 invariant hypervector_negate_flips_all_trits: C-style for (i = 0; i < 100; i += 1) -> for (0..100) |i|, body unchanged. NOT CHECKED markers in the Zig output: 1 -> 0.
  • parse-complete --show: packed_vsa 19 -> nothing discarded; sdk 56 -> nothing discarded.
  • Typecheck unchanged (OK, 0 warnings each). Zig ast-check: the same pre-existing error set before and after (9 and 28); test-report BLOCKED on both before and after for the same reasons.
  • The four seals regenerated with the t27c built from this tree; --verify reports all hashes MATCH.
  • Both parse-no-discard entries removed from docs/reports/suite_expectations.json; local t27c suite --ratchet --corpus-only: RATCHET CLEAN.

🤖 Generated with Claude Code

…e not discarded (#5738)

packed_vsa's self-similarity test ended in 'then sim ≈ 1.0' and fell back
whole (gen emitted an empty test); sdk's hypervector_negate_flips_all_trits
used a C-style for loop and gen emitted 'NOT CHECKED'. They are now
'abs(sim - 1.0) < 1e-6' and 'for (0..100) |i| { ... }' with the same body.
Seals regenerated with this tree's t27c; both parse-no-discard ledger
entries are removed.

Closes #5738

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-03 10:25:02 UTC

Summary

Status Count
Total Open PRs 44
PRs with Failing Checks 39
PRs with All Checks Green 5
READY 1
FAILING 39
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 39 + 0 + 0 = 40, and there are 44 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=b45a356c2eb6 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vsa specs: a check written with '≈' and a C-style for loop are discarded by the parser

1 participant