specs/vsa: write the '≈' check and the C-style loop in t27 so they are not discarded - #5739
Merged
Merged
Conversation
…e not discarded (#5738) packed_vsa's self-similarity test ended in 'then sim ≈ 1.0' and fell back whole (gen emitted an empty test); sdk's hypervector_negate_flips_all_trits used a C-style for loop and gen emitted 'NOT CHECKED'. They are now 'abs(sim - 1.0) < 1e-6' and 'for (0..100) |i| { ... }' with the same body. Seals regenerated with this tree's t27c; both parse-no-discard ledger entries are removed. Closes #5738 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5738
Two VSA checks were written in notation the t27 parser does not read, so they were silently discarded.
packed_vsa.t27testpacked_cosine_self_similarity_is_one:then sim ≈ 1.0->then abs(sim - 1.0) < 1e-6(comment says what "approximately" means). On mastert27c genemitted this test with an empty body; now it computes and asserts.sdk.t27invarianthypervector_negate_flips_all_trits: C-stylefor (i = 0; i < 100; i += 1)->for (0..100) |i|, body unchanged.NOT CHECKEDmarkers in the Zig output: 1 -> 0.parse-complete --show: packed_vsa 19 ->nothing discarded; sdk 56 ->nothing discarded.ast-check: the same pre-existing error set before and after (9 and 28);test-reportBLOCKED on both before and after for the same reasons.--verifyreports all hashes MATCH.parse-no-discardentries removed fromdocs/reports/suite_expectations.json; localt27c suite --ratchet --corpus-only: RATCHET CLEAN.🤖 Generated with Claude Code