The seal gate is back: a merge her verdict refused had made it one comment line - #5454
Merged
Merged
Conversation
…mment line (#5453) #5183 (branch queen-5158, merged 2026-09-29 with the Queen's verdict `escalate`) replaced tools/check_seal_coverage.py, 688 lines, with "# No changes made to this file; only the baseline was updated." An empty Python file exits 0, so the coverage job and its --self-check negative control have reported success since then while checking nothing. Restored byte-for-byte from bcb32d7^. Measured at master with t27c built from master's bootstrap/: the self-check passes; the real run reports 649 seals that do not hold (540 stale, 109 gen-drift), up from 131 when the gate went. Re-sealing them is the owner's decision (#5158 said so); this restores the instrument, not a verdict on the 649. Closes #5453 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Oct 1, 2026
This was referenced Oct 1, 2026
dmitrii-f-t27
added a commit
that referenced
this pull request
Oct 2, 2026
…ds changes, and after a red ratchet (Refs #5453) (#5489) tools/check_gate_preconditions.py runs six gates on an empty tree and names any that exit 0 with nothing to check. Given master's one-line tools/check_seal_coverage.py it says, in under two seconds: VACUOUS check_seal_coverage.py [bare] exits 0 with nothing to check It never got to say it, for two independent reasons: - fpga-build.yml listed only two of the six gates in its path filters, so #5183 -- which emptied check_seal_coverage.py on 2026-09-29 and touched nothing else but a docs/now entry -- never started it. - Since a90bdac (2026-09-22) every master run of fpga-conformance has failed at "Elaboration errors may fall, never rise", and GitHub skips every later step, this control included. So the other four gates in its table and tools/_prereq.py (which it plants them with) join both path lists, and the step runs with `if: always()`, the idiom bootstrap-tests and corpus-ratchet already use. It reads the built t27c and the tree, never the ratchet's verdict; when t27c did not build it reports UNRUN, which is red and true. On this PR the step is expected to report VACUOUS for check_seal_coverage.py: master still carries the one-line file until #5454 lands. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 2, 2026
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-10-02 03:27:04 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5453
#5183 (branch
queen-5158, merged 2026-09-29) replacedtools/check_seal_coverage.py, 688 lines, with the single line# No changes made to this file; only the baseline was updated.The Queen's verdict on that issue wasescalate: she did not accept it. An empty Python file exits 0, socoverageand its--self-checknegative control have reported success since then while checking nothing.This restores the file byte-for-byte from
bcb32d723^.Measured locally, at master, with t27c built from master's
bootstrap/python3 tools/check_seal_coverage.py --self-checkexits 0. Every planted case lands on the right branch, and the legend covers 8 of 8 kinds.python3 tools/check_seal_coverage.pyexits 1: 649 seals do not hold (540 stale, 109 gen-drift). There were 131 when the gate was removed.Expect
coverageto be red on this PR. That is the restored instrument telling the truth.coverageis not among master's required checks today (validate,check-linked-issue,parse-ratchet), so it blocks nothing.Not done here, and an owner decision: re-sealing the 649, or which of them are spec bugs rather than seal debt. #5158 said so itself.
🤖 Generated with Claude Code